Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdp: convert to JsonBuilder, and use applayer incomplete #5195

Closed
wants to merge 2 commits into from

Conversation

lmzke
Copy link
Contributor

@lmzke lmzke commented Jul 16, 2020

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Resolves two issues earmarked for 6.0.0rc1:

  • rdp: remove parser buffering code (for 3539)
  • rdp/eve: convert to jsonbuilder (for 3715)

In addition to CI, cargo test and suricata-verify both pass as well.

Feedback welcome.

@lmzke lmzke requested review from jasonish, victorjulien and a team as code owners July 16, 2020 14:33
@lmzke lmzke changed the title Rdp.3539.4 rdp: convert to JsonBuilder, and use applayer incomplete Jul 16, 2020
@victorjulien
Copy link
Member

Thanks Zach, could you please split the commits that do functional changes from the commits that do reformatting?

@lmzke
Copy link
Contributor Author

lmzke commented Jul 18, 2020

Continued in #5199.

@lmzke lmzke closed this Jul 18, 2020
@lmzke lmzke deleted the rdp.3539.4 branch July 22, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants