Next/20210312/v3 #5977
Merged
Next/20210312/v3 #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per flow IP-only flags are checked and set by IP-only engine, so no need to set/check them per alert.
Use a simpler reject check and move logic into util func.
When adding the alert to a drop record make sure the add the highest priority. It would until now add all drops from high to low prio, effectively overwriting the record each time. Ticket OISF#4397
If suricata-update is not available on "make install-full", don't exit 1, instead give the reason why its not installed, but still succeed the install.
according to the comment
Codecov Report
@@ Coverage Diff @@
## master #5977 +/- ##
==========================================
- Coverage 76.79% 76.77% -0.02%
==========================================
Files 612 612
Lines 188368 188363 -5
==========================================
- Hits 144656 144624 -32
- Misses 43712 43739 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Mar 13, 2021
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
May 25, 2023
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5976 #5973 #5972 #5969
suricata-verify-pr: 472