-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pcre2 3194 v21 #6414
Merged
Merged
Pcre2 3194 v21 #6414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcre2 substrings need special free...
Needs maybe to be generalized
catenacyber
requested review from
norg,
victorjulien and
a team
as code owners
September 28, 2021 15:47
Closed
Codecov Report
@@ Coverage Diff @@
## master #6414 +/- ##
==========================================
- Coverage 77.06% 77.05% -0.02%
==========================================
Files 613 613
Lines 186492 186696 +204
==========================================
+ Hits 143724 143855 +131
- Misses 42768 42841 +73
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 4377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3194
https://redmine.openinfosecfoundation.org/issues/4446
Describe changes:
suricata-verify-pr: 502
OISF/suricata-verify#502
Replaces #6413 with latest rebase and removing commit suppressing drmemory file which will keep obsolete pcre1 references