Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcre2 3194 v21 #6414

Merged
merged 12 commits into from
Sep 29, 2021
Merged

Pcre2 3194 v21 #6414

merged 12 commits into from
Sep 29, 2021

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3194
https://redmine.openinfosecfoundation.org/issues/4446

Describe changes:

  • migrate all pcre1 code to pcre2
  • qa : remove some obsolete files
  • pcrexform : checks that we have exactly one substring capture in a signature

suricata-verify-pr: 502

OISF/suricata-verify#502

Replaces #6413 with latest rebase and removing commit suppressing drmemory file which will keep obsolete pcre1 references

@catenacyber catenacyber mentioned this pull request Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #6414 (bce3c46) into master (98f84d5) will decrease coverage by 0.01%.
The diff coverage is 80.13%.

@@            Coverage Diff             @@
##           master    #6414      +/-   ##
==========================================
- Coverage   77.06%   77.05%   -0.02%     
==========================================
  Files         613      613              
  Lines      186492   186696     +204     
==========================================
+ Hits       143724   143855     +131     
- Misses      42768    42841      +73     
Flag Coverage Δ
fuzzcorpus 53.00% <70.91%> (-0.01%) ⬇️
suricata-verify 51.77% <47.76%> (+0.02%) ⬆️
unittests 62.99% <62.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 4377

@victorjulien victorjulien merged commit bce3c46 into OISF:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants