-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Userguide: clarify lua's need
key usage differences (Doc#4725) - v1
#6480
Conversation
The differences on how the `need` key works, depending on script usage (output or detection) confuses users, sometimes (cf doc#4725). While we don't fix that, just explain this behavior.
Since we can have scripts for output _or_ detection, it seems more clear to rename this page to add more meaning
Codecov Report
@@ Coverage Diff @@
## master #6480 +/- ##
==========================================
+ Coverage 77.05% 77.08% +0.02%
==========================================
Files 613 613
Lines 186733 186734 +1
==========================================
+ Hits 143890 143938 +48
+ Misses 42843 42796 -47
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
||
function init (args) | ||
local needs = {} | ||
needs["packet"] = tostring(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do false
and "false"
mean the same thing in Lua?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do:
print(type("false"))
print(type(false))
First will print string
, second will print boolean
But print(type(tostring(false)))
and print(type(tostring("false")))
both are strings...
Not sure if this answers your question 😅
WARNING:
Pipeline 4661 |
🤔 |
I wouldn't worry about it. A lot of the small stats (especially these ones that came about after the flow fix a couple weeks ago) are nothing major. |
Thanks, was especially curious because this supposedly only changed documentation pages... |
Merged in #6642, thanks! |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4725
Describe changes:
need
in case of detection script