Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix inherent to string #6547

Closed

Conversation

TheKharleeci
Copy link
Contributor

@TheKharleeci TheKharleeci commented Oct 31, 2021

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4618

Ticket: #4618
Prev-PR: #6516

Describe changes:

  • ntlmssp_records:-Add fix to inherent_to_string warning
  • Remove #!allow(clippy::inherent_to_string) clippy lint from rust/src/lib.rs

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #6547 (a5b260d) into master (416575e) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6547      +/-   ##
==========================================
- Coverage   77.14%   77.06%   -0.08%     
==========================================
  Files         613      613              
  Lines      186735   186750      +15     
==========================================
- Hits       144052   143922     -130     
- Misses      42683    42828     +145     
Flag Coverage Δ
fuzzcorpus 52.96% <ø> (-0.06%) ⬇️
suricata-verify 52.08% <ø> (-0.07%) ⬇️
unittests 63.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Nov 1, 2021
@victorjulien
Copy link
Member

Merged as part of #6552, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants