Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/siggroup: convert unittests to FAIL/PASS APIs v2 #6617

Conversation

ghostinthehive
Copy link
Contributor

Previous-PR #6612

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket: #4028

Describe changes:

  • Convert unittests SigGroupHeadTest* to use FAIL/PASS APIs
  • Cleanup unittests
  • Update Copyright year

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #6617 (50b6c0d) into master (244dd11) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6617      +/-   ##
==========================================
- Coverage   77.08%   77.05%   -0.04%     
==========================================
  Files         613      613              
  Lines      186171   186017     -154     
==========================================
- Hits       143519   143343     -176     
- Misses      42652    42674      +22     
Flag Coverage Δ
fuzzcorpus 52.92% <ø> (-0.06%) ⬇️
suricata-verify 52.15% <ø> (+0.02%) ⬆️
unittests 63.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@victorjulien victorjulien mentioned this pull request Nov 22, 2021
@victorjulien
Copy link
Member

Merged in #6629, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants