Next/20220103/v3 #6744
Merged
Next/20220103/v3 #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that DNS servers will still process a DNS request even if the z-bit is set, our parser will fail the transaction. So create the transaction, but still set the event. Ticket OISF#4924
[Edit by Jason Ish: fix flag bit value] Ticket OISF#4515
Ticket: 4920 Completes commit c8dbe24 which introduced AppProtoEquals to have a generic check for http in signature can mean http1 or http2 in traffic. This commit missed this case, as I only looked for git grep "alproto ==" and here we deal with alproto_tc and alproto_ts, but not alproto by itself.
Many places were still referencing the old Suricata page. Used git grep with replace to update them. Checked that new links work. Left old references when they were only documentation examples (for output or unittests). Task#4915
This commit adds support for enabling libunwind -- a library that can be used to display stack information. Libunwind is enabled and used by Suricata if present during configuration. A diagnostic message is displayed if libunwind cannot be found.
This commit adds an error code for the diagnostic code used for diagnostic messages following unexpected termination due to signals..
This commit adds a configuration setting to enable a stack trace message if Suricata receives a signal that terminates execution, such as SIGSEGV, SIGABRT.
This commit adds a signal handler for SIGSEGV when configured. The signal handler emits a one line stack trace using SCLogError. The intent is to provide diagnostic information in deployments where core files are not possible. The diagnostic message is from the offending thread and includes the stack trace; each frame includes the symbol + offset.
victorjulien
requested review from
inashivb,
jasonish,
norg and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6744 +/- ##
==========================================
- Coverage 77.17% 77.13% -0.04%
==========================================
Files 616 616
Lines 185662 185664 +2
==========================================
- Hits 143276 143205 -71
- Misses 42386 42459 +73
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6739
#6733
#6731
#6729