Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smtp/50x/v1 #7213

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Smtp/50x/v1 #7213

merged 2 commits into from
Apr 8, 2022

Conversation

victorjulien
Copy link
Member

Missing SMTP backports.

Ticket: 4948

This is not the perfect solution, but it prevents to trigger
the assert, and keep the assert.
A better solution would need to create transaction from
the reponse parsing, in case a later command was buffered and
not answered. But this would not be enough as NoNewTx prevents
the creation of a new transaction for RSET...

(cherry picked from commit 4247605)
Ticket: 4948

When parsing the response for starttls

(cherry picked from commit 99b3443)
@victorjulien victorjulien requested a review from a team as a code owner April 7, 2022 09:32
@victorjulien victorjulien added the needs ticket Needs (link to) redmine ticket label Apr 7, 2022
@suricata-qa
Copy link

ERROR:

ERROR: QA failed on tlpr1_alerts_cmp.

Pipeline 6832

@victorjulien victorjulien merged commit 2535f41 into OISF:master-5.0.x Apr 8, 2022
@victorjulien victorjulien deleted the smtp/50x/v1 branch July 17, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs ticket Needs (link to) redmine ticket
Development

Successfully merging this pull request may close these issues.

4 participants