Quic ietf 4967 v20 #7678
Merged
Quic ietf 4967 v20 #7678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can use new functions in quic parser
so that we can use hkdf crate for quic
The format of initial packet for quic ietf, ie quic v1, is described in rfc 9000, section 17.2.2 Parse more frames and logs interesting extensions from crypto frame Do not try to parse encrypted data, ie after we have seen a crypto frame in each direction. Use sni from crypto frame with tls for detection already implemented Ticket: OISF#4967
Logging as is done in TLS. Detection using the generic generic ja3.string keyword Ticket: OISF#5143
adding ja3 and extension fields
Closed
Codecov Report
@@ Coverage Diff @@
## master #7678 +/- ##
==========================================
- Coverage 75.93% 75.92% -0.01%
==========================================
Files 659 659
Lines 185639 185669 +30
==========================================
+ Hits 140958 140963 +5
- Misses 44681 44706 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 8464 |
Merged
victorjulien
approved these changes
Aug 3, 2022
|
Thanks Philippe, nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4967
https://redmine.openinfosecfoundation.org/issues/5143
https://redmine.openinfosecfoundation.org/issues/5166
Describe changes:
suricata-verify-pr: 783
OISF/suricata-verify#783
Replaces #7676 fixing commit-check