Next/20220827/v2 #7787
Merged
Next/20220827/v2 #7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is file sent with POST or PUT Ticket: OISF#4144
Add tls.random keyword that matches on the 32 bytes of the TLS random field for client as well as server. Add tls.random_time keyword that matches on the first 4 bytes of the TLS random field for client as well as server. Add tls.random_bytes keyword that matches on the last 28 bytes of the TLS random field for client as well as server. All these are sticky buffers. Feature 5190
Frame::len is -1 if it is still unknown. Handle that in the debug check.
For protocols with multi buffer inspection there could be multiple times the same sid would be queued into the candidates queue. This triggered a debug validation check. W/o debug validation this would lead to duplicate work and possibly multiple alerts where a single one would be appropriate. Bug: 5419.
Codecov Report
@@ Coverage Diff @@
## master #7787 +/- ##
==========================================
- Coverage 76.08% 76.05% -0.03%
==========================================
Files 662 663 +1
Lines 185776 185872 +96
==========================================
+ Hits 141350 141372 +22
- Misses 44426 44500 +74
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 8843 |
This was referenced Aug 29, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
Various fixes
Previous PR: #7782