Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next/20220920/v15 #7882

Closed
wants to merge 26 commits into from
Closed

Next/20220920/v15 #7882

wants to merge 26 commits into from

Conversation

victorjulien
Copy link
Member

victorjulien and others added 26 commits September 20, 2022 11:24
@victorjulien
reputation: fix multiline test
e9c4b37
@victorjulien
reputation: add ipv6 cidr test
c3c5829
@victorjulien
debug: remove empty header
e250ef6
@victorjulien
app-layer: fix compiler warning
b9ad1d1
@victorjulien
ipfw: remove unused func prototype
faca974
@victorjulien
htp: remove user setup from request line callback
18e63d4 
This used to be the first callback that was called, but its not anymore.

Codecov confirmed that this is no longer used and therefore not useful.
@victorjulien
common: move u8_tolower to common header
19e94e9
@victorjulien
flow-manager: reduce locks at startup
0e39c92 
Effectively busy looping on a mutex to wait for time to be ready.
@victorjulien
github-ci: bump cbindgen to 0.24.3
6e12207 
This addresses issues around the AppLayerTxData type.
@victorjulien
etc/schema: clang (re)format
036686e
@victorjulien
tls: make SSLSetEvent a macro to help debugging
dbf3d1e
@victorjulien
eve/tls: warn on unsupported 'custom' options
224ba82
@victorjulien
detect/tls: add tls.cert_chain_len keyword
682e2a0
@victorjulien
tls: improve versions extension logic
1a4e9e1 
Skip over unusable versions like GREASE.

Introduce a function to check if a version is valid.
@victorjulien
detect/profiling: track bytes scanned by prefilter engines
179acbd
@victorjulien
detect/build: minor code cleanup
3bd92fb
@jlucovsky @victorjulien
detect/uri: Remove unnecessary include
a25dfc9 
This commit removes an unnecessary #include for detect-uricontent.h
@jlucovsky @victorjulien
detect/tls: Improve tls.fingerprint rule handling
f2f312d 
Issue: 4581

This commit improves the runtime performance of rules with
tls.fingerprint by using the inspection logic from tls.cert_fingerprint.
@catenacyber @victorjulien
mqtt: remove quadratic time complexity
a5fb903 
When having many transactions in a single parsing call...

Fix has overhead of having one more field in the mqtt state.

Completes commit a8079dc

Ticket: OISF#5399
@catenacyber @victorjulien
pgsql: config limit maximum number of live transactions
b1a8687 
As is done for other protocols

Ticket: OISF#5527
@satta @victorjulien
ebpf: update deprecated API calls
6dcb0b5 
This fixes build errors when libbpf 1.0 is used. It removes previously
deprecated API functions that were still in use in Suricata's eBPF
code.
@catenacyber @victorjulien
flow/icmpv4: fix vlan.use-for-tracking
b11747b 
For ICMPv4 error messages the vlan ids were always considered,
even if the 'vlan.use-for-tracking' option was disabled.

Ticket: OISF#5330
@catenacyber @victorjulien
detect: adds flow.age keyword
d0b7830 
Ticket: OISF#5536
@AndreiShchepa @victorjulien
dpdk/i40e: fix warning with number of queues for RSS configuration
5ae13ec
@dependabot @victorjulien
github-actions: bump ossf/scorecard-action from 1.1.2 to 2.0.3
1d8b2cd 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 1.1.2 to 2.0.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@ce330fd...865b409)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@glebius @victorjulien
ipfw: remove setting of SO_BROADCAST on the divert(4) socket
6f66b1b 
My review of the FreeBSD kernel code reveals that this setting
a) is ignored by the kernel b) is not required.  The sending
side of divert(4) never checks so->so_options, but always gives
IP_ALLOWBROADCAST to ip_output().
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #7882 (6f66b1b) into master (a9a17c8) will increase coverage by 0.22%.
The diff coverage is 48.80%.

@@            Coverage Diff             @@
##           master    #7882      +/-   ##
==========================================
+ Coverage   75.85%   76.08%   +0.22%     
==========================================
  Files         666      668       +2     
  Lines      186269   185996     -273     
==========================================
+ Hits       141301   141509     +208     
+ Misses      44968    44487     -481
Flag Coverage Δ
fuzzcorpus 60.77% <42.47%> (+0.28%) ⬆️
suricata-verify 52.73% <42.20%> (+0.13%) ⬆️
unittests 60.70% <28.57%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Sep 20, 2022
Merged
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW1_stats_chk
.tcp.rst 126232 102786 81.43%
SURI_TLPR1_stats_chk
.flow.memuse 562615488 637500928 113.31%
.app_layer.error.http.parser 1548 1103 71.25%

Pipeline 9350

@victorjulien
Copy link
Member Author

replaced by #7884

@victorjulien victorjulien deleted the next/20220920/v15 branch September 29, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
7 participants
@victorjulien @suricata-qa @jlucovsky @catenacyber @satta @AndreiShchepa @glebius