Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowhash livedev 5270 v2 #7950

Closed
wants to merge 3 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5270

Describe changes:

  • flow: optionally use livedev for hash

Should it be optional ? Ie does suricata support having 2 interfaces monitoring the same network (and flows) ?

Modifies #7386 with needed rebase after merge of #7861

Meaning that we support 65535 live devices at the most
For easier reasoning about the code
So that in a setup with different interfaces capturing different
networks, flows do not get mixed up

Ticket: OISF#5270
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #7950 (96e93e2) into master (db5cf1f) will increase coverage by 0.00%.
The diff coverage is 45.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7950   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         949      949           
  Lines      273740   273759   +19     
=======================================
+ Hits       224998   225023   +25     
+ Misses      48742    48736    -6     
Flag Coverage Δ
fuzzcorpus 64.27% <39.43%> (+0.01%) ⬆️
suricata-verify 59.42% <45.07%> (-0.02%) ⬇️
unittests 63.95% <26.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW1_stats_chk
.tcp.rst 126120 103158 81.79%

Pipeline 9737

@jlucovsky
Copy link
Contributor

Continued in #7972

@jlucovsky jlucovsky closed this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants