Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix lint warnings about mixed case hex literals #8005

Closed
wants to merge 1 commit into from

Conversation

AkakiAlice
Copy link
Contributor

Ticket: #4593

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4593

Previous PR: #8003

Describe changes:

  • Update commit message

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @AkakiAlice ! LGTM. :)

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #8005 (ffb16d9) into master (2158dbf) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8005      +/-   ##
==========================================
- Coverage   81.65%   81.62%   -0.03%     
==========================================
  Files         953      953              
  Lines      275749   275749              
==========================================
- Hits       225158   225082      -76     
- Misses      50591    50667      +76     
Flag Coverage Δ
fuzzcorpus 63.69% <0.00%> (+0.31%) ⬆️
suricata-verify 58.89% <0.00%> (-0.04%) ⬇️
unittests 63.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 18, 2022
@jasonish
Copy link
Member

Merged via #8051, Thanks!

@jasonish jasonish closed this Oct 25, 2022
@AkakiAlice AkakiAlice deleted the lint-optimization-4593-v2 branch October 28, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

4 participants