-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfb: add unittests for nom7 parsers #8272
Conversation
} | ||
|
||
//done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not mean to commit these comments. Will remove them now( I added this for parsers whose unit tests are there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git tip: git add -p <path to file>
to manually select which changes should be staged for commit
@@ -36,7 +36,7 @@ pub enum RFBGlobalState { | |||
TSVncResponse, | |||
TCSecurityResult, | |||
TSClientInit, | |||
Message | |||
Message, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please split formatting changes from the test additions into separate commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.Will address in next PR
Followed by #8276 |
Link to redmine ticket:
Describe changes: