http2: remove http2.header keyword #8615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it had a different behavior than http.header and this was confusing. The behavior of matching on only one header at a time is now available through the http.request_header and http.response_header keywords. Ticket: OISF#5780
|
Previous PR was #8371 |
|
Looks like I need to modify S-V tests... |
|
WARNING:
Pipeline 12794 |
|
The ticket suggests doing just |
Closed
|
Going on in #8621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5780
Describe changes:
http.headerhttp2.request_headerandhttp2.response_headerwhich match an individual header@victorjulien do you also want to add the individual header matching on HTTP1 ? and have the keyword be
http.request_header