Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5780
Describe changes:
http.header
Replaces #8615 with added commit to add the HTTP1 functionality
I have lots of questions...
Should this be one commit ?
Even if it is renaming + adding HTTP1 functionality
Did I get right the use of HttpHeaderBuffer ?
Is src/detect-http-header.c the right file do put it ?
I removed the validation callback as it is HTTP2-specific
Should we just remove the escaping being done in HTTP2, and not be able to match differently on a HTTP2 header name having comma in it like
x: y
versus a HTTP2 header having x as its name and y as its value ?How do we merger with S-V having some test with rules with the keyword being deprecated ?
Do we keep the deprecated keyword in 6 ?
suricata-verify-pr: 1153
OISF/suricata-verify#1153