Improving DPDK capture interface and docs v7 #8859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 10, 2023 14:27
Function rte_eth_stats_get is not thread-safe and the result is only used by one thread. Running with multiple workers led to very high values in rx_missed counters (buffer-overflow-like behavior). Ticket: OISF#6006
Segmented mbufs should never happen in Suricata. Mbuf segmentation divides the received packet into multiple mbufs. This can happen when MTU of the NIC is larger than the allocated mbufs in the mbuf mempool. As Suricata sets the size of the mbuf to be slightly higher than the configured MTU, mbuf segmentation should never happen in Suricata. This is especially true, if Suricata runs as a primary process and configures the packet source (NIC). Processing segmented mbufs can lead to missed/false (pattern-matching) detections as Suricata only inspects the first segment of the packet. It can also lead to segfault if Suricata moves the detection window out of the segment boundaries.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8859 +/- ##
==========================================
+ Coverage 82.25% 82.28% +0.03%
==========================================
Files 969 969
Lines 273176 273176
==========================================
+ Hits 224689 224782 +93
+ Misses 48487 48394 -93
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
|
Information: QA ran without warnings. Pipeline 13724 |
|
Merged in #8861, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #8811
Links to the Redmine tickets:
https://redmine.openinfosecfoundation.org/issues/5857
https://redmine.openinfosecfoundation.org/issues/5858
https://redmine.openinfosecfoundation.org/issues/5859
https://redmine.openinfosecfoundation.org/issues/5937
https://redmine.openinfosecfoundation.org/issues/5936
https://redmine.openinfosecfoundation.org/issues/5925
https://redmine.openinfosecfoundation.org/issues/5923
https://redmine.openinfosecfoundation.org/issues/6006
https://redmine.openinfosecfoundation.org/issues/5963
Changes: