Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output alert applayer v6 #8961

Closed
wants to merge 30 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
None, preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
Continuation of #8772
https://redmine.openinfosecfoundation.org/issues/5977

Describe changes:

  • Fix setup-app-layer script so that it adds app-layer metadata to alerts
  • Adds ftp metadata to alerts
  • Adds tftp metadata to alerts
  • Adds krb5 metadata to alerts
  • Removes tx_id from ssh and http2 logging

Continues #8922 with review taken into account

SV_BRANCH=pr/1196

OISF/suricata-verify#1196

Still to do :
Any ideas about the commit segmentation ? and PR splitting ?
I guess I should make a first smaller version with uncontroversial changes

Especially fix setup-app-layer script to not forget this part
and used by bittorrent
And fix setup app layer script up for it
This was referenced Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #8961 (f6cb529) into master (6154bab) will decrease coverage by 0.01%.
The diff coverage is 97.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8961      +/-   ##
==========================================
- Coverage   82.42%   82.41%   -0.01%     
==========================================
  Files         969      957      -12     
  Lines      273476   272917     -559     
==========================================
- Hits       225410   224934     -476     
+ Misses      48066    47983      -83     
Flag Coverage Δ
fuzzcorpus 65.02% <84.52%> (+0.08%) ⬆️
suricata-verify 60.42% <97.02%> (-0.09%) ⬇️
unittests 63.04% <24.40%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

field baseline test %
TREX_GENERIC_stats_chk
.capture.kernel_drops 0 172 0.00

Pipeline 14239

@catenacyber catenacyber added the needs rebase Needs rebase to master label Jun 7, 2023
@catenacyber
Copy link
Contributor Author

Waiting for #8977 merge before rebasing

@catenacyber
Copy link
Contributor Author

Keeping it open because there is more here than in #9005

@suricata-qa
Copy link

Information:

field baseline test %
TREX_GENERIC_stats_chk
.capture.kernel_drops 0 172 0.00

Pipeline 14239

@catenacyber
Copy link
Contributor Author

Closing for now
#9252 has a part of this, and more will be reused from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
3 participants