Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: remove unused #9014

Closed
wants to merge 1 commit into from
Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
None, generic cleaning

Describe changes:

  • rust: remove unused dead code

Found with
git grep 'pub ' rust/src/ | cut -d: -f1 | uniq | xargs sed -i -e 's/pub /pub(crate) /' then see rust warnings when compiling

There is nothing more to be done :

  • There are parsed fields which get never used. (like rrclass in DNSQueryEntry) : I feel good to keep them
  • get_child_value and append_hex are kept for API completeness

Completes #8976

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #9014 (e1b137c) into master (14ecfeb) will decrease coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9014      +/-   ##
==========================================
- Coverage   82.31%   82.18%   -0.13%     
==========================================
  Files         969      969              
  Lines      273559   273573      +14     
==========================================
- Hits       225171   224833     -338     
- Misses      48388    48740     +352     
Flag Coverage Δ
fuzzcorpus 64.25% <ø> (-0.43%) ⬇️
suricata-verify 60.45% <ø> (-0.03%) ⬇️
unittests 62.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.flow.memuse 519171056 742435272 143.0%

Pipeline 14447

@catenacyber catenacyber mentioned this pull request Jun 13, 2023
@catenacyber
Copy link
Contributor Author

Replaced by #9020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants