rust: remove unused #9020
Closed
rust: remove unused #9020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9020 +/- ##
==========================================
+ Coverage 82.26% 82.31% +0.04%
==========================================
Files 969 969
Lines 273740 273617 -123
==========================================
+ Hits 225203 225230 +27
+ Misses 48537 48387 -150
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 14487 |
catenacyber
force-pushed
the
rust-unused-v7
branch
from
e99b6d6
to
c422b0c
Compare
|
Information: QA ran without warnings. Pipeline 14729 |
Closed
|
Rebased in #9256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, generic cleaning
https://redmine.openinfosecfoundation.org/issues/4083
Describe changes:
Found with
git grep 'pub ' rust/src/ | cut -d: -f1 | uniq | xargs sed -i -e 's/pub /pub(crate) /'then see rust warnings when compilingThere is nothing more to be done :
rrclassin DNSQueryEntry) : I feel good to keep themCompletes #8976, modifies #9014 by being more complete as agreed with Jason