Warn integers downcast 64to32 6186 v1 #9105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
commented
Jun 29, 2023
| @@ -686,7 +686,7 @@ static uint32_t AppLayerProtoDetectProbingParserGetMask(AppProto alproto) | |||
| FatalError("Unknown protocol detected - %u", alproto); | |||
| } | |||
|
|
|||
| SCReturnUInt(1UL << (uint32_t)alproto); | |||
| SCReturnUInt(1 << (uint32_t)alproto); | |||
There was a problem hiding this comment.
Should AppLayerProtoDetectProbingParserGetMask return a u64 ?
But then flow structure needs to grow 2 u32 into 2 u64...
There was a problem hiding this comment.
Because we will soon have more than 32 app-layer protocols, right ?
catenacyber
commented
Jun 29, 2023
| @@ -60,7 +60,7 @@ typedef struct Frame { | |||
| typedef struct Frames { | |||
| uint16_t cnt; | |||
| uint16_t dyn_size; /**< size in elements of `dframes` */ | |||
| uint32_t left_edge_rel; | |||
| uint64_t left_edge_rel; | |||
There was a problem hiding this comment.
@victorjulien is this correct for frames ?
There was a problem hiding this comment.
no it's u32 intentionally, it's relative to something, I think the stream base seq. So when used it's added to that other thing.
catenacyber
commented
Jun 29, 2023
| @@ -53,8 +53,8 @@ typedef struct { | |||
| { \ | |||
| .secs = 0, .usecs = 0 \ | |||
| } | |||
| #define SCTIME_USECS(t) ((uint64_t)(t).usecs) | |||
| #define SCTIME_SECS(t) ((uint64_t)(t).secs) | |||
There was a problem hiding this comment.
@jlucovsky do you remember the reason for the cast ?
|
Also draft to get CI feedback. |
|
WARNING:
Pipeline 14912 |
Closed
|
Replaced by #9117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32flag to clang after-Wimplicit-int-conversionProvide values to any of the below to override the defaults.
OISF/libhtp#396
Draft : is this the way to go ?
Make multiple PRs for this redmine ticket
I will remove the CI commit in the next version, but so, we have some red feedback to see what is still to be fixed