Warnint 64to32 6186 v2 #9117
Closed
Warnint 64to32 6186 v2 #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING:
Pipeline 14934 |
Closed
|
Replaced by #9155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32flag to clang after-Wimplicit-int-conversionProvide values to any of the below to override the defaults.
OISF/libhtp#396
Modifies #9105 by changing fix for frames, and fixing ubsan
Draft : is this the way to go ?
Make multiple PRs for this redmine ticket
I will remove the CI commit in the next version when it gets stable, but so, we have some red feedback to see what is still to be fixed