Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/143/20231006/v1 #9570

Closed
wants to merge 5 commits into from
Closed

next/143/20231006/v1 #9570

wants to merge 5 commits into from

Commits on Oct 6, 2023

  1. doc/code-submission: add commit sign guide

    @inashivb @victorjulien
    inashivb authored and victorjulien committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    85806e8 View commit details
    Browse the repository at this point in the history

  2. rust: update broti decompressor crate 

    cf https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59687
    @catenacyber @victorjulien
    catenacyber authored and victorjulien committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7202ae2 View commit details
    Browse the repository at this point in the history

  3. doc/install: link to devguide's install from git 

    Although we have an updated version of instructions for installation
from git, our install guide was only referring to RedMine, which is less
up-to-date.

Kept that reference, since it might still be useful for non-Ubuntu
cases.
    @jufajardini @victorjulien
    jufajardini authored and victorjulien committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f35039d View commit details
    Browse the repository at this point in the history

  4. doc/quickstart: add software-properties instruction 

    This is indicated in the `Installation` section, but not in the
quickstart, and it felt like a valid addition, here, too.
    @jufajardini @victorjulien
    jufajardini authored and victorjulien committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    80173e0 View commit details
    Browse the repository at this point in the history

  5. output/email: use SCCalloc for OutputJsonEmailCtx 

    email_ctx->fields only gets populated when smtp.custom setting is on.
The fn EveEmailLogJSONCustom is called when either
1. smtp.extended setting is on or,
2. email_ctx->fields is populated which means smtp.custom setting is on

In case neither of these are set in suricata.yaml, no call should
ideally be made to the fn EveEmailLogJSONCustom.
However, it turns out that email_ctx->fields is unset and then set only
after the smtp config was found. This leads to email_ctx->fields
sometimes contain value even when no config was given to the smtp
section and can lead to unexpected output.

Fix this by using SCCalloc while initializing OutputJsonEmailCtx struct
instead of SCMalloc.

Bug 6380
    @inashivb @victorjulien
    inashivb authored and victorjulien committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5dbebc0 View commit details
    Browse the repository at this point in the history