-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next/143/20231006/v1 #9570
next/143/20231006/v1 #9570
Conversation
Although we have an updated version of instructions for installation from git, our install guide was only referring to RedMine, which is less up-to-date. Kept that reference, since it might still be useful for non-Ubuntu cases.
This is indicated in the `Installation` section, but not in the quickstart, and it felt like a valid addition, here, too.
email_ctx->fields only gets populated when smtp.custom setting is on. The fn EveEmailLogJSONCustom is called when either 1. smtp.extended setting is on or, 2. email_ctx->fields is populated which means smtp.custom setting is on In case neither of these are set in suricata.yaml, no call should ideally be made to the fn EveEmailLogJSONCustom. However, it turns out that email_ctx->fields is unset and then set only after the smtp config was found. This leads to email_ctx->fields sometimes contain value even when no config was given to the smtp section and can lead to unexpected output. Fix this by using SCCalloc while initializing OutputJsonEmailCtx struct instead of SCMalloc. Bug 6380
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9570 +/- ##
==========================================
+ Coverage 82.20% 82.21% +0.01%
==========================================
Files 968 968
Lines 274275 274275
==========================================
+ Hits 225461 225507 +46
+ Misses 48814 48768 -46
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however one typo in one commit subject that I missed earlier:
rust: update broti decompressor crate
broti should be brotli.
Seeing we have some documentation-related merges here, could you see if this is good to be merged? |
Closing as there are still issues, see above. |
Staging: