Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: be consistent with the use of "sudo" - v7 #9601

Closed
wants to merge 1 commit into from
Closed

doc: be consistent with the use of "sudo" - v7 #9601

wants to merge 1 commit into from

Conversation

0xEniola
Copy link
Contributor

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5720

Previous PR: #9599

Describe changes:

  • Incorporate feedback from last PR.
  • Correct commit subject.
  • Corrected the document regression; document was not up to date with the master branch.

inashivb
inashivb approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@inashivb inashivb added the outreachy Contributions made by Outreachy applicants label Oct 12, 2023
@github-actions
Copy link

NOTE: This PR may contain new authors:

Daniel Olatunji <danielolatunji20@outlook.com>

This was referenced Oct 27, 2023
Closed
Merged
@victorjulien
Copy link
Member

Merged in #9701, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@victorjulien victorjulien victorjulien approved these changes

@inashivb inashivb inashivb approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees
No one assigned
Labels
cla complete outreachy Contributions made by Outreachy applicants
Milestone
No milestone
4 participants
@0xEniola @victorjulien @jasonish @inashivb