Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/152/20231028/v1 #9701

Merged
merged 9 commits into from Oct 30, 2023
Merged

next/152/20231028/v1 #9701

merged 9 commits into from Oct 30, 2023

Conversation

victorjulien
Copy link
Member

0xEniola and others added 9 commits October 28, 2023 07:29
@0xEniola @victorjulien
doc: be consistent with the use of "sudo"
0e5fdbb 
Issue: OISF#5720
@0xEniola @victorjulien
rust/doc: add docstring to rust module files.
5c0af0b 
Issue: OISF#4584
@0xEniola @victorjulien
rust: remove cbindgen:ignore on frames module
54de045 
This directive is no longer required, and does
mess up the rustdoc description of the module.
@zazie-codes @victorjulien
misc: improve code documentation
3b15589 
Task OISF#6383
@hadiqaalamdar @victorjulien
util-misc: Convert unittests to new FAIL/PASS API
47a11c7 
Task OISF#6345
@hadiqaalamdar @victorjulien
flow-bit: Convert unittests to new FAIL/PASS API
4ff52f2 
Task OISF#6329
@hadiqaalamdar @victorjulien
detect-tcp-window: Convert unittests to new FAIL/PASS API
68d3c0c 
Task OISF#6339
@jufajardini @victorjulien
userguide: add proper label to RPM install section
54d8f45 
Use a reference label that is stable, instead of one that could change
in case a new section is added above it.
@jufajardini @victorjulien
github: improve template CLA request info
a985143 
Indicate that the CLA only has to be signed once, as we have had
contributors think that was required for each new PR.
@github-actions
Copy link

NOTE: This PR may contain new authors:

Daniel Olatunji <danielolatunji20@outlook.com>
Hadiqa Alamdar Bukhari <hadiqaalamdar@gmail.com>
Liza Opar <oparliza@gmail.com>

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #9701 (a985143) into master (2fe2d82) will increase coverage by 0.08%.
The diff coverage is 99.20%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9701      +/-   ##
==========================================
+ Coverage   82.39%   82.48%   +0.08%     
==========================================
  Files         968      968              
  Lines      274337   274083     -254     
==========================================
+ Hits       226047   226074      +27     
+ Misses      48290    48009     -281
Flag Coverage Δ
fuzzcorpus 64.75% <0.00%> (+0.05%) ⬆️
suricata-verify 60.90% <0.00%> (-0.02%) ⬇️
unittests 62.91% <99.20%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16332

@victorjulien victorjulien merged commit a985143 into OISF:master Oct 30, 2023
47 checks passed
This was referenced Oct 30, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
7 participants
@victorjulien @suricata-qa @jasonish @0xEniola @zazie-codes @hadiqaalamdar @jufajardini