Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve code documentation- v5 #9650

Closed
wants to merge 1 commit into from

Conversation

zazie-codes
Copy link
Contributor

@zazie-codes zazie-codes commented Oct 18, 2023

Task #6383

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:https://redmine.openinfosecfoundation.org/issues/6383

Describe changes:
This is an update of #9649
-squashed all commits.
-added the space in layer src/app-layer-htp-libhtp.h
-interchanged file description to come after author credentials to conform to guidelines.

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 18, 2023
@github-actions
Copy link

NOTE: This PR may contain new authors:

Liza Opar <oparliza@gmail.com>

@zazie-codes
Copy link
Contributor Author

I've noticed a clang format error. Im correcting it right now.

@jufajardini
Copy link
Contributor

I've noticed a clang format error. Im correcting it right now.

Nice :)

I'm a bit confused with the CI checks, as they seem to be linking the checks to PR #9611. Could you please, just in case, rebase your branch to Suricata newest master, when applying the formatting fixes? Not sure what is making GH link the workflows like that...

@zazie-codes
Copy link
Contributor Author

I've noticed a clang format error. Im correcting it right now.

Nice :)

I'm a bit confused with the CI checks, as they seem to be linking the checks to PR #9611. Could you please, just in case, rebase your branch to Suricata newest master, when applying the formatting fixes? Not sure what is making GH link the workflows like that...

In not certain but could it be because i used a new branch that the master will commit from?

@github-actions
Copy link

NOTE: This PR may contain new authors:

Liza Opar <oparliza@gmail.com>

@jufajardini
Copy link
Contributor

I've noticed a clang format error. Im correcting it right now.

Nice :)
I'm a bit confused with the CI checks, as they seem to be linking the checks to PR #9611. Could you please, just in case, rebase your branch to Suricata newest master, when applying the formatting fixes? Not sure what is making GH link the workflows like that...

In not certain but could it be because i used a new branch that the master will commit from?

Not sure, but Shivani re-ran the CI checks, and now it has passed. Maybe github had a hiccup...

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks :)

This was referenced Oct 27, 2023
@victorjulien
Copy link
Member

Merged in #9701, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
4 participants