-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve code documentation- v5 #9650
Conversation
NOTE: This PR may contain new authors:
|
I've noticed a clang format error. Im correcting it right now. |
Nice :) I'm a bit confused with the CI checks, as they seem to be linking the checks to PR #9611. Could you please, just in case, rebase your branch to Suricata newest master, when applying the formatting fixes? Not sure what is making GH link the workflows like that... |
b7262c4
to
7f06911
Compare
In not certain but could it be because i used a new branch that the master will commit from? |
NOTE: This PR may contain new authors:
|
Not sure, but Shivani re-ran the CI checks, and now it has passed. Maybe github had a hiccup... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks :)
Merged in #9701, thanks! |
Task #6383
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:https://redmine.openinfosecfoundation.org/issues/6383
Describe changes:
This is an update of #9649
-squashed all commits.
-added the space in layer src/app-layer-htp-libhtp.h
-interchanged file description to come after author credentials to conform to guidelines.