Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printable/v4 #9854

Closed
wants to merge 2 commits into from
Closed

Printable/v4 #9854

wants to merge 2 commits into from

Conversation

victorjulien
Copy link
Member

This avoids looping over partly duplicate segments that cause
output data corruption by logging parts of the stream data multiple
times.

For data with GAPs now add a indicator '[4 bytes missing]' similar
to how Wireshark does it.

Bug: OISF#6553.
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #9854 (dd14fdb) into master (90c1765) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9854      +/-   ##
==========================================
- Coverage   82.47%   82.43%   -0.04%     
==========================================
  Files         973      973              
  Lines      273962   273967       +5     
==========================================
- Hits       225944   225852      -92     
- Misses      48018    48115      +97     
Flag Coverage Δ
fuzzcorpus 64.34% <100.00%> (-0.04%) ⬇️
suricata-verify 61.08% <96.77%> (-0.03%) ⬇️
unittests 62.87% <3.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien marked this pull request as draft November 21, 2023 12:45
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 184 197 107.07%

Pipeline 16669

@catenacyber catenacyber added the needs rebase Needs rebase to master label Nov 23, 2023
@victorjulien victorjulien mentioned this pull request Nov 24, 2023
@victorjulien
Copy link
Member Author

replaced by #9885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
3 participants