Printable/v13 #9885
Closed
Printable/v13 #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed a workaround cast for RBTREE use.
Modeled after the same option in eve/alert. Defaults to 4k.
This avoids looping over partly duplicate segments that cause output data corruption by logging parts of the stream data multiple times. For data with GAPs now add a indicator '[4 bytes missing]' similar to how Wireshark does it. Bug: OISF#6553.
Don't init buffer to 0 size but use the desired default of 4k.
In preparation of stream logging changes.
Log using stream callback API, meaning that data will also be logged if there are GAPs. Also implement GAP indicators: '[123 bytes missing]'.
For better readability and type checking.
victorjulien
commented
Nov 24, 2023
| ssn, stream, FrameJsonStreamDataCallback, &cbd, frame->offset, &unused, false); | ||
| /* if we have all data, but didn't log until the end of the frame, we have a gap at the | ||
| * end of the frame | ||
| * TODO what about not logging due to buffer full? */ |
There was a problem hiding this comment.
could perhaps end with something like [3124 more bytes]
There was a problem hiding this comment.
or simpler, just something like [...]
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9885 +/- ##
==========================================
- Coverage 82.45% 82.43% -0.02%
==========================================
Files 972 972
Lines 273057 273102 +45
==========================================
- Hits 225156 225143 -13
- Misses 47901 47959 +58
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16719 |
Closed
|
Replaced by #10261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/6553
SV_BRANCH=OISF/suricata-verify#1493
replaces #9854