userguide: fix css for readthedocs hosted userguide - v1 #9933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our conf.py we reference some ReadTheDocs stylesheets that appear to be old and break formatting of some items like bulletted lists. Bug: OISF#6589
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9933 +/- ##
==========================================
+ Coverage 82.35% 82.37% +0.02%
==========================================
Files 972 972
Lines 273060 273060
==========================================
+ Hits 224870 224940 +70
+ Misses 48190 48120 -70
Flags with carried forward coverage won't be shown. Click here to find out more. |
jufajardini
approved these changes
Nov 30, 2023
victorjulien
approved these changes
Dec 1, 2023
Merged
|
Merged in #9939, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we were just using outdated CSS files, so instead, don't manually
bring in any ReadTheDocs CSS files.
Bug: https://redmine.openinfosecfoundation.org/issues/6589
Example of current broken output (note the actions list without bullets):
https://docs.suricata.io/en/suricata-7.0.2/rules/intro.html#action
And with this patch:
https://jasonish-suricata.readthedocs.io/en/latest/rules/intro.html#action
There will be other changes as well by using newer CSS, one appears to be extra spacing in the main TOC as can be seen here:
https://jasonish-suricata.readthedocs.io/en/latest/index.html