Structure project in the boltdb-inspired-way

[ilyaglow]

Why

Attempt to address #41

Summary

Main parts of gobuster package that I picked:

• dir.go
• dns.go
• helpers.go
• output.go
• parsecmd.go
• state.go

How to try this out

git fetch origin pull/42/head:reorganize-main
git checkout reorganize-main
cd cmd/gobuster
go run main.go -h

Links

Boltdb reference

Any suggestions are welcomed

[OJ]

Thank you @ilyaglow! I'm away at a conference for the rest of the week, but I promise to take a look at this as soon as I can afterwards. Cheers!

[OJ]

Thanks again @ilyaglow, I'm back home now and will look at this very soon!

[OJ]

@ilyaglow I haven't forgotten about you mate :) I'll be sorting this out soon. Thanks again!

[OJ]

OK milestone added, coming soon!

[0xdevalias]

Any updates on this @OJ ?

[0xdevalias]

So.. I've been trying to figure out how to cleanly merge/rebase the work I have done on #54 onto this, while keeping all of @ilyaglow's commits/changes, and I think I just want to ragequit IT and go cry in a corner somewhere dislike rebasing.

I would like to bring them into alignment, but I don't really know how to make it work without going and manually rewriting all the changes.

Edit: At this stage I think I will just continue making my changes on my branch, refactoring things as I go, and keeping this layout in mind as I do. Would rather invest my time on improving core functionality instead of trying to figure rebasing.

Edit2: Put a WIP-style branch up where I manually copied the changes across into the same structure.

• https://github.com/alias1/gobuster/tree/run-from-code-plus-illya

[OJ]

To begin with, this PR will get merged first. From there I'll be pulling things in from other branches.

Apologies for the delay, I've been a bit on the busy front of late!

[OJ]

OK so the current working branch is https://github.com/OJ/gobuster/tree/1.4-dev which has the first stages of changes from @ilyaglow and has the adjustments from @alias1. I'd love it if you guys could cast your eyes on it a bit and let me know what you think.

I like the libgobuster idea so that it can be included from other apps. Future work would do more to separate UI level stuff from the lib code as well.

Thanks folks!

[ilyaglow]

Great to see this rolls :)

Summarizing changes in 1.4-dev, I like that ParseCmdLine is moved to the main package and the use of go-multierror. Basically I was trying to do the same as @alias1 and the goal was to use gobuster as a library from other apps.

The main difference is that I tried to stay more "goish" with packaging. I think if we plan to add another libsomething dependency folder to gobuster when it is totally right thing but otherwise it is a little cumbersome to import github.com/OJ/gobuster/libgobuster vs github.com/OJ/gobuster, but I'm not against it.

[OJ]

Good point :)

[0xdevalias]

Will reply to the rest of this when I'm on a real computer, but my main motivation for the 'libgobuster' paradigm was to not break 'current compatibility' with the install instructions. I'm more than happy to (and would prefer) the cmd styled subfolder. Paves way for some potential CLI improvement via cobra if you're up for it later.

[0xdevalias]

Had a quick skim through the code in 1.4-dev and looks like it has all the things :) Thanks for merging @OJ !

[ilyaglow]

Seems this one can be closed, thanks guys!

[OJ]

I'm going to keep this open until it's landed in master. Thanks!