-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aurikatech (SA: RET12) - Compliance Check #1764
Comments
Hi @Jagannath-wits , Can you please clarify our doubts about the below questions?
|
|
Hi @Jagannath-wits provider/items/1 : Return fulfillment for the item_id a9fd801c-3673-4305-93fe-78bd7fa95cd2 should be created at on_update_picked for the above issue the items array contains 2 items one is for the Delivery, another for the part_cancel . We don't add the item for returns in this request. In on_update_picked it was created, so you can also observe that the number of items in the items array increases to 3. provider/items/0 : Tags are not required in the item with id: a9fd801c-3673-4305-93fe-78bd7fa95cd2 Also here the tags are only available for the Delivery item not for the cancelled item or return item . |
|
@Jagannath-wits we have made all the above fixes and the changes have been merged in this PR. Can you please review and confirm if we can get Tech Log clearance for our retail flows? |
Flow 1on_search_full_catalog_refresh
Flow 2on_status_picked
Flow 4on_cancel
Flow 5on_cancel
Flow 6on_status_picked
on_init
confirm
on_update_part_cancel
update_settlement_part_cancel
on_update_interim_reverse_qc
on_update_approval
on_update_picked
on_update_delivered
|
Hi @Jagannath-wits ,
returnFF/start/person/name: "returnFF/start/person/name is not a required attribute as per the API contract" Why these were not flagged in the first iteration only ? we should have fixed them also in the first go only. As for your question rtoFFObj/end/time: Fulfillment type rto end/time should not be present in /on_cancel when state/desc/code is RTO-Initiated. We will resolve this issue surely in this iteration , we missed this in the previous one . |
@Jagannath-wits we have fixed all the above issues and are changes have been merged. Can you please review our logs now? |
Aurikatech Flow 1on_search
on_search
Flow 2On_initOnly @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount,@ondc/org/settlement_details are required in payment object as only buyer is collecting payment currently. Incase seller wants to collect the payment then you can send it the way you sent but then it wont change in confirm call; right now payment is only accepted by buyer on network so the payment object in confirm is correct Flow 3on_select_oosSelect multiple items for flow 3 as mentioned in rollout plan Flow 5on_cancelYou can charge for delivery in this as the order was already out for delivery Flow 6####/on_update (part cancel)
on_status_pickedInvoice should’ve been updated after part-cancel (repeated) |
@Jagannath-wits we have fixed all the above issues and are changes have been merged. Can you please review our logs now? |
Flow 1On_search
Flow 4on_init
Flow 6on_init
on_confirm
on_status_out_for_delivery
@vanshraghav please fix repeated issues in next iteration |
Flow 1/on_search
/on_search (inc)
Flow 2/on_init
/on_confirm
/on_status
Flow 3
/on_select
Flow 4
/on_cancel
Flow 5
/on_cancel
Flow 6
/on_status (pending)
/on_update (part cancel)
/on_update (approved)
/on_update (picked)
|
|
- No, in those logs details were provided in start which was not required as mentioned @pareenjain |
|
@Jagannath-wits @sandeepshahi can you please respond to the above? |
@sandeepshahi @Jagannath-wits we have addressed these issues, and the logs were merged in this PR. Can you please review these? |
Flow 1on_search
on_search_inc
Flow 3on_select_out_of_stock
Flow 5on_cancel_rto
on_status_rto_delivered
Flow 6on_update_part_cancel
|
@Jagannath-wits @sandeepshahi I think our items is being updated correctly only; we're part cancelling 2 items of the 5 items - no? |
Acknowledged |
@sandeepshahi @Jagannath-wits we have addressed #1764 (comment), and the logs were merged in the PR #2166. Can you please review our logs? |
Flow 1/on_search
/on_search (inc)
Flow 2/on_init
/on_status
Flow 3
Flow 5/on_cancel
Flow 6/on_update (part cancel)
/on_update (approved)
/on_update (picked)
|
|
@pareenjain, also, make sure the fees and charges in quote/breakup are feasible and not placeholder values |
Changes merged in this PR. |
Flow 1/on_search
/on_search (inc)
Flow 2/on_status
Flow 3
common issues:
@pareenjain, please resubmit logs for Flow 3 and answer the above mentioned queries |
As of now, we are only supporting item updates in incremental search. We plan to extend support to Scenarios 2-5 as well (i.e., all scenarios except offers), but hopefully that doesn't become a blocker for us to roll-out our MVP in Prod because the remaining scenarios should be taken care of in the full catalog search requests.
We are calculating delivery TAT dynamically based on the pickup and delivery pincodes. |
@sandeepshahi - we raised this PR resubmitting logs for Flow 1, 2, 3 - fixing all the above issues you've highlighted. If you can merge this and let us know if our logs can now be approved for preprod. |
/on_status
@pareenjain, Please resolve the above issue and complete the pending submissions on the NP Portal for QA. |
@sandeepshahi on the above, we have ensured a 3-day TAT between:
Isn't this correct? |
Flow 1
on_search_full_catalog_refresh
tmpstmp
: Timestamp difference between/on_search
and/search
should be less than 5 seconds.prvdr0categories
: Support for variants is mandatory; categories must be present inbpp/providers[0]
.prvdr0/tags/timing/Delivery
: The timings object must be present for Delivery in the tags.desc
: Short description (short_desc
) and long description (long_desc
) should be different.search_inc_refresh
tmpstmp
: Timestamp for/on_search
API cannot be greater than or equal to/inc_search
API.on_search_inc_refresh
on_search_inc_refresh_msgId
: Message ID should not be the same as previous calls since it's an incremental push-based call.tmpstmp
: Context/timestamp difference between/on_search_inc
and/inc_search
should be less than 5 seconds.tmpstmp/
: Timestamp for/on_search
API cannot be greater than or equal to/on_search_inc
API.Flow 2
on_init
message.order
:'cancellation_terms'
in/message/order
should not be provided as they are not enabled yet.invoice
: invoice should be publically accessibleon_status_delivered
payment/status
: Why the payment status is 'NOT-PAID' even after the delivery and when the payment/type: "ON-FULFILLMENT"Flow 3
on_select_out_of_stock
error.message
: Theerror.message
provided in theon_select_out_of_stock
should be in the form of an array with propererror_code
anditem_id
. For example:[ {"item_id":"I1","error":"40002"}, {"item_id":"I2","error":"40002"}, {"item_id":"I3","error":"40002"} ]
Flow 4
on_cancel
inititated_by
: This should be bap_idFlow 5
on_cancel
rtoFFObj/end/time
: Fulfillment typerto end/time
should not be present in/on_cancel
whenstate/desc/code
isRTO-Initiated
.inititated_by
: This should be bpp_idFlow 6
on_status_delivered
payment/status
: Why the payment status is 'NOT-PAID' even after the delivery and when the payment/type: "ON-FULFILLMENT"on_status_picked
invoice
: invoice should be publically accessible, please remove any expiration from the urls; It should also be update after part_cancelon_update_part_cancel
status
: Why the payment status is'NOT-PAID'
.on_update_interim_reverse_qc
status
: Why the payment status is'NOT-PAID'
.message/order.payment/@ondc/org/settlement_details/0
: Missingpayment/@ondc/org/settlement_details
compared toupdate_settlement_part_cancel
, i.e.{ "settlement_counterparty":"buyer", "settlement_phase":"refund", "settlement_type":"upi", "settlement_amount":"472899.32", "settlement_timestamp":"2024-05-29T09:13:38.327Z" }
provider/items/0
: Tags are not required in the item with id:a9fd801c-3673-4305-93fe-78bd7fa95cd2
on_update_approval- Same as above
Return.start.location.id
: Return fulfillment start location ID is not required inon_update_approval
.returnFF/start/time/range/start
: Start/time/range/start time of return fulfillment should be greater than context/timestamp ofon_update_approval
.on_update_picked
status
: Why the payment status is'NOT-PAID'
.message/order.payment/@ondc/org/settlement_details/0
: Missingpayment/@ondc/org/settlement_details
compared toupdate_settlement_part_cancel
Return.start.location.id
: Return fulfillment start location ID is not required inon_update_picked
.invldQuoteTrailPrices
: Quote trail price and item quote price sum foron_update
should be equal to the price as inon_confirm
. The fulfillment_id 6656f2cef274d6d7d7b293de has different price in quote_trail and quote. Why ?on_update_delivered
status
: Why the payment status is'NOT-PAID'
.message/order.payment/@ondc/org/settlement_details/0
: Missingpayment/@ondc/org/settlement_details
compared toupdate_settlement_part_cancel
Return.start.location.id
: Return fulfillment start location ID is not required inon_update_delivered
.invldQuoteTrailPrices
: Quote trail price and item quote price sum foron_update
should be equal to the price as inon_confirm
. The fulfillment_id 6656f2cef274d6d7d7b293de has different price in quote_trail and quote. Why ?@vanshraghav
The text was updated successfully, but these errors were encountered: