[bug] No warning when editing a comment to an empty comment

[sorikang0806]

Describe the bug
There is no warning or error message that notifies the user that an edited comment cannot be empty.

To Reproduce
Steps to reproduce the behaviour:

1. Write a comment eg. on one of the research threads
2. Click on Edit comment
3. Remove all the characters and make an empty comment then save
4. It doesn't change the original comment

Expected behaviour
When the save button is clicked, display a warning message that a comment cannot be empty

Screenshots

Additional context
I am a newbie here and want to try fixing this bug myself first if that is okay!

[benfurber]

Thanks @sorikang0806, a really good spot!

Looks like the EditComment component and the CreateComment component should share more code so that the behaviour is consistent.

[V24039]

Hi, I would like to work on this. After looking through the code I have made some obs

• For CreateComment the button is disabled if the comment length is 0 i.e. no input is given. As the button is disabled I feel that an error message is not required.
• For EditComment the store procedure function editComment is trimming the comment and checking it hence the original comment is not changed. It will require a validation at EditComment to show an error message to the user.

[benfurber]

Thanks for your notes @V24039. I agree there's a challenge with how CreateComment is basically implemented completely differently to EditComment.

I see @npaddle has jumped on this too! :) Will add some feedback there too.

[onearmy-bot]

🎉 This issue has been resolved in version 1.183.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀