Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds missing eslint dep #1233

Merged
merged 1 commit into from Oct 6, 2021
Merged

Conversation

thisislawatts
Copy link
Collaborator

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Thanks to the report from @tiefpunkt, this PR introduces the eslint as an explicit dev dependency rather than making the assumption has the tool installed on their machine.

@cypress
Copy link

cypress bot commented Oct 6, 2021



Test summary

68 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 4868a92
Started Oct 6, 2021 11:55 AM
Ended Oct 6, 2021 12:04 PM
Duration 08:31 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke self-requested a review October 6, 2021 14:31
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to tidy this

@chrismclarke chrismclarke merged commit 285ab4a into master Oct 6, 2021
@chrismclarke chrismclarke deleted the chore/add-missing-eslint-dep branch October 6, 2021 14:48
@thisislawatts
Copy link
Collaborator Author

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants