fix: hide member mappins on precious plastic

[benfurber]

PR Checklist

• - Commit messages are descriptive, it will be used in our Release Notes

PR Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Developer experience (improves developer workflows for contributing to the project)

Description

A more robust attempt at trying to hide member pins by default on PP. This fixes two problems:

1. While it worked locally, how the platform version is selected for production builds is different.
2. The pins were hidden completely and couldn't be filtered if a user wanted to.

I tried first to apply the logic necessary to the display components but I didn't find an approach that worked so I applied it to the store logic instead.

Git Issues

Closes #2927

[github-actions]

Visit the preview URL for this PR (updated for commit eaffb5b):

https://onearmy-next--pr3000-2927-2-hide-member-m-t4pzmo7c.web.app

_{(expires Wed, 27 Dec 2023 22:30:47 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59}

[benfurber]

I'm getting a different behaviour on the preview branch than locally. Reverting to a draft.

[cypress]

1 flaky test on run #4623 ↗︎

0

190

0

0

1

Details:

feat: allow member pins to still be selected on pp
Project: onearmy-community-platform	Commit: eaffb5b7c2
Status: Passed	Duration: 04:29 💡
Started: Nov 25, 2023 7:06 PM	Ended: Nov 25, 2023 7:10 PM

  src/integration/SignUp.spec.ts • 1 flaky test • ci-firefox

View Output

Test		Artifacts
[Sign-up - new user] > sign in as new user		Screenshots

Review all test suite changes for PR #3000 ↗︎

[davehakkens]

Thanks for the try @benfurber. Feel free to leave it for someone else if it gets to complex. Can be challenging with all the instances and configurations

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e222691) 56.21% compared to head (eaffb5b) 56.25%.

Files	Patch %	Lines
src/stores/Maps/maps.store.ts	0.00%	8 Missing ⚠️
src/pages/Maps/Content/Controls/Controls.tsx	0.00%	5 Missing ⚠️
...ges/Maps/Content/Controls/GroupingFilterMobile.tsx	0.00%	2 Missing ⚠️
src/config/config.ts	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3000      +/-   ##
==========================================
+ Coverage   56.21%   56.25%   +0.03%     
==========================================
  Files         345      345              
  Lines       11247    11253       +6     
  Branches     1934     1940       +6     
==========================================
+ Hits         6323     6330       +7     
+ Misses       4876     4875       -1     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benfurber]

@davehakkens Thanks for the offer Dave. The issue yesterday was just some incomplete logic I'd written. The behaviour is what is required now, just the issue of checking my new approach to determining PP for production...

[onearmy-bot]

🎉 This PR is included in version 1.127.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[davehakkens]

Should be released but member pins are still here.. @benfurber
Or am I missing something?

[benfurber]

@davehakkens Next time a build is release can you please check this again? It turns out that REACT_APP_PLATFORM_THEME wasn't being set as an environment variable for the production build of PP.