Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security-rules): unblock v3 categories #3552

Merged
merged 1 commit into from
May 21, 2024

Conversation

thisislawatts
Copy link
Collaborator

@thisislawatts thisislawatts commented May 16, 2024

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

What this PR does

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (a0745ff) to head (c535a27).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3552      +/-   ##
==========================================
+ Coverage   68.19%   68.29%   +0.10%     
==========================================
  Files         441      441              
  Lines       13936    13936              
  Branches     2490     2490              
==========================================
+ Hits         9503     9517      +14     
+ Misses       4385     4371      -14     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented May 16, 2024

1 flaky test on run #5616 ↗︎

0 82 1 0 Flakiness 1

Details:

fix(security-rules): unblock v3 categories
Project: onearmy-community-platform Commit: c535a2739f
Status: Passed Duration: 04:37 💡
Started: May 16, 2024 7:57 PM Ended: May 16, 2024 8:02 PM
Flakiness  src/integration/howto/read.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
... > [See all info] Test Replay Screenshots Video

Review all test suite changes for PR #3552 ↗︎

firestore.rules Show resolved Hide resolved
@mariojsnunes mariojsnunes marked this pull request as ready for review May 21, 2024 04:23
@mariojsnunes mariojsnunes requested a review from a team as a code owner May 21, 2024 04:23
@mariojsnunes mariojsnunes merged commit 47bc7f0 into master May 21, 2024
19 checks passed
@mariojsnunes mariojsnunes deleted the fix/unblock-v3-categories branch May 21, 2024 04:23
@cypress cypress bot mentioned this pull request May 21, 2024
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.183.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.182.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants