add functions to manage user.stats.userCreatedComments #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
approved these changes
May 21, 2024
|
Nice one. Same comment about manual testing as the other one. |
This was referenced May 21, 2024
|
Tested manually and working :) |
|
@goratt12 Now I've merged in your other branch, I think you've got some fun merge conflicts here now? |
2 flaky tests on run #5670 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| [Settings] > Focus Plastic Collection Point > [Edit a new profile] |
Test Replay
Screenshots
Video
|
|
howto/comments.spec.ts • 1 flaky test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| [How To Commenting] > [By Authenticated] > [Commenting] |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #3557 ↗︎
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3557 +/- ##
==========================================
+ Coverage 68.23% 68.32% +0.09%
==========================================
Files 444 445 +1
Lines 13935 13972 +37
Branches 2507 2509 +2
==========================================
+ Hits 9509 9547 +38
+ Misses 4378 4377 -1
Partials 48 48 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.183.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.185.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
Using Firebase Functions
Git Issues
Closes #3451
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.