Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added damping and user load function in Spring Mass example #481

Merged
merged 7 commits into from
May 16, 2022
Merged

Added damping and user load function in Spring Mass example #481

merged 7 commits into from
May 16, 2022

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented May 14, 2022 •
edited by jorgepz

closes #314
closes #472

@jorgepz jorgepz changed the title Added damping and user load function in Spring Mass exmaple Added damping and user load function in Spring Mass example May 14, 2022
@jorgepz
Copy link
Member

jorgepz commented May 14, 2022

Could you add here the plot of the example? Just to see how it matches the solution? Thanks!

@mvanzulli
Copy link
Member Author

mvanzulli commented May 14, 2022 •
edited

Could you add here the plot of the example? Just to see how it matches the solution? Thanks!

It happens something curious if I declare the boundaryConds(2) as empty (line 139 of spirngMass.m) then It don't matches the analytic solution:

bug

@mvanzulli mvanzulli requested a review from jorgepz May 14, 2022 14:06
@jorgepz
Copy link
Member

jorgepz commented May 14, 2022

Raro.... debería dar exactamente igual... sugiero q mires las matrices de masa... deberían ser iguales...

@jorgepz
Copy link
Member

jorgepz commented May 14, 2022

I would increase the final time... And if necessary reduce the deltat. And see what do we get in the plot....

@mvanzulli @jorgepz
Update examples/springMass/springMass.m
926dbfa 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli
Copy link
Member Author

I would increase the final time... And if necessary reduce the deltat. And see what do we get in the plot....

This are the results:
Results

It seems that if BC is declared as an empty struct then the error increases with time 👎

@jorgepz
Copy link
Member

jorgepz commented May 16, 2022

seems to be working...
image
will merge.

@jorgepz
Copy link
Member

jorgepz commented May 16, 2022

i will do some tests... to see whats going on here! 😟

@jorgepz jorgepz self-assigned this May 16, 2022
@jorgepz jorgepz marked this pull request as draft May 16, 2022 11:25
@jorgepz jorgepz marked this pull request as ready for review May 16, 2022 11:45
@jorgepz jorgepz merged commit e9a36fd into master May 16, 2022
@jorgepz jorgepz deleted the mvanzulli/springMass branch May 16, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz approved these changes

Assignees

@jorgepz jorgepz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add working userloadfunc use example extend cases in springmass problem
2 participants
@mvanzulli @jorgepz