Break the rabbit URL into its component variables #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcox-dev
suggested changes
May 14, 2019
app/rabbit_helper.py
Outdated
| exchange_name=RABBIT_EXCHANGE, | ||
| queue_name=RABBIT_QUEUE, | ||
| queue_args=RABBIT_QUEUE_ARGS): | ||
| """ | ||
| Initialise connection to rabbitmq | ||
|
|
||
| :param rabbitmq_amqp: The amqp (url) of the rabbitmq connection | ||
| :param parameters: The CollectionParameters for the connection |
There was a problem hiding this comment.
parameters doesn't exist in init_rabbitmq parameter list?
| parameters = pika.ConnectionParameters(RABBIT_HOST, RABBIT_PORT, RABBIT_VIRTUALHOST, credentials) | ||
|
|
||
| logger.debug('Connecting to rabbitmq', url=parameters.host) | ||
| return pika.BlockingConnection(parameters) |
|
Can be merged once these are merged: |
jcox-dev
approved these changes
May 17, 2019
davidmort
approved these changes
May 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 96.61% 96.72% +0.11%
==========================================
Files 4 4
Lines 118 122 +4
==========================================
+ Hits 114 118 +4
Misses 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently the only way to set the RabbitMQ connection variables is via the compond URL parameters. This isn't ideal for when we'll want to be able to pull in the username and password from Kubernetes secrets.
What has changed
Breaks out the Rabbit URL into its component parameters.
How to test?
make test