Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

Adds maps lib, go-bindata-assetfs, go / node image #39

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

joegasewicz
Copy link
Contributor

@joegasewicz joegasewicz commented Apr 13, 2022

What

Describe what you have changed and why.

  • Pulling the correct ONS map library (dp-maps-js)
  • Adds assetfs
    • Removed the -debug flag from the make debug cmd as there is a bug running go-bindata-assetfs

How to review

pull down the branch, and hit make debug

Describe the steps required to test the changes.

navigate to http://127.0.0.1:26600/areas/E92000001 there should be a map displayed

Who can review

myself
Describe who worked on the changes, so that other people can review.
anyone

@joegasewicz joegasewicz changed the title adds dist to assets Adds maps lib, go-bindata-assetfs fork, go / node image Apr 13, 2022
@joegasewicz joegasewicz force-pushed the feature/static-script-versions branch 7 times, most recently from 80faa33 to 7ceec89 Compare April 13, 2022 12:22
dist

dist

chnages

changes

changes

changes

changes

changes

changes

changes

changes

removes fork
@joegasewicz joegasewicz force-pushed the feature/static-script-versions branch from 7ceec89 to 40fbba7 Compare April 19, 2022 08:27
@joegasewicz joegasewicz changed the title Adds maps lib, go-bindata-assetfs fork, go / node image Adds maps lib, go-bindata-assetfs, go / node image Apr 19, 2022
@joegasewicz joegasewicz merged commit be82e91 into develop Apr 20, 2022
@joegasewicz joegasewicz deleted the feature/static-script-versions branch April 20, 2022 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants