Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to Thank you page #284

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Add icons to Thank you page #284

merged 4 commits into from
Sep 16, 2020

Conversation

berroar
Copy link
Contributor

@berroar berroar commented Sep 15, 2020

What is the context of this PR?

The green tick and padlock icons were missing from the census-thank-you page, this PR updates the template so that they appear.

How to review

Use any of the test_thank_you schemas and check the missing icons now appear on the page.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@berroar
Copy link
Contributor Author

berroar commented Sep 15, 2020

Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be on all variations?. I.e non census theme etc

@berroar
Copy link
Contributor Author

berroar commented Sep 15, 2020

They should be on all variations?. I.e non census theme etc

I've added the green tick to the non census page now, but not sure if the padlock needs to be there? Doesn't really match the text

@MebinAbraham
Copy link
Contributor

They should be on all variations?. I.e non census theme etc

I've added the green tick to the non census page now, but not sure if the padlock needs to be there? Doesn't really match the text

Might be worth checking with Donna.

@berroar
Copy link
Contributor Author

berroar commented Sep 16, 2020

Confirmed with @donnap573 that there is no need for the padlock icon on the non census thank you page.

@berroar berroar merged commit 593dfa6 into master Sep 16, 2020
@berroar berroar deleted the update-thankyou-page branch September 16, 2020 09:18
@pricem14pc pricem14pc added this to the v3.49.0 milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants