New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent IR request link from appearing on all interstitial pages #310
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
279f45d
Make initial changes
petechd 47ada7d
Add logic
petechd 01b3070
Refactor if conditions
petechd 71a436f
Merge branch 'master' into fix-request-link
petechd 7297452
Remove list item id check
petechd 14c8ae3
Merge branch 'fix-request-link' of github.com:ONSdigital/eq-questionn…
petechd b84f9c5
Add review changes
petechd 5335b9b
Update app/views/handlers/__init__.py
petechd dc4c3d7
Add review changes
petechd 61997cc
Merge branch 'master' into fix-request-link
petechd 28bc326
Remove repetition
petechd 2a3ef4f
Merge branch 'master' into fix-request-link
petechd 50cd252
Move method to content block and rename
petechd 47ed188
Merge branch 'master' into fix-request-link
petechd 0381d03
Move method to questionnaire schema class
petechd a445a32
Remove method from a list
petechd 269760e
Add test and new interstitial
petechd a951414
Rename method
petechd 289960f
Move method to content handler
petechd 87af948
Add review changes
petechd 91ddfda
Merge branch 'master' into fix-request-link
petechd e55bff1
Implement new method in individual_response file
petechd 70b09be
Merge branch 'fix-request-link' of github.com:ONSdigital/eq-questionn…
petechd 68b63c6
Reformat method
petechd b18d919
Fix method typo
petechd 13d4eed
Fix integration test
petechd 358e589
Update test_schemas/en/test_individual_response.json
petechd c19aa5e
Move ir method to its group
petechd File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to group this with the other IR methods in this class for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to ir group now.