Juno support

[pascal-brand38]

No description provided.

[pascal-brand38]

@cedric-chaumont-st @jenswi-linaro Could you check Juno building and running, using also OP-TEE/manifest#6? Thanks.

[pascal-brand38]

Juno and clean are fixed.

[cedric-chaumont-st-dev]

FYI: Build. Boot. Test w/o GP OK.
GP test on going.

[cedric-chaumont-st-dev]

Tested-by: Cedric Chaumont cedric.chaumont@linaro.org (ARM Juno board)
48211 subtests of which 0 failed
701 test cases of which 0 failed
0 test case was skipped
TEE test application done!

[jenswi-linaro]

We need to document the source of the binary files.

[jenswi-linaro]

By the way, are we allowed to distribute those binary files (patches/bl30.bin and patches/bl33.bin)?

[pascal-brand38]

Fix the missing \

[jforissier]

This is not correct, because for ARM TF some flags such as CFLAGS have to be passed as environment variables (otherwise they override the values set in the Makefile and you lose some required flags), while some others can indeed be passed as make arguments.

With the above I get the following error:

  DEPS    build/hikey/release/bl31/plat_io_storage.d
plat/hikey/plat_io_storage.c:32:26: fatal error: arch_helpers.h: No such file or directory
 #include <arch_helpers.h>

Here is what works for me:

ARM_TF_FLAGS ?= \
    CROSS_COMPILE="$(CCACHE)$(AARCH64_CROSS_COMPILE)" \
    BL32=$(OPTEE_OS_BIN) \
    BL33=$(EDK2_BIN) \
    NEED_BL30=yes \
    BL30=$(MCUIMAGE_BIN) \
    DEBUG=$(DEBUG) \
    PLAT=hikey \
    SPD=opteed

ARM_TF_EXPORTS ?= CFLAGS="-O0 -gdwarf-2"

arm-tf: mcuimage optee-os edk2
    export $(ARM_TF_EXPORTS) ; \
    $(MAKE) -C $(ARM_TF_PATH) $(ARM_TF_FLAGS) all fip

arm-tf-clean:
    export $(ARM_TF_EXPORTS) ; \
    $(MAKE) -C $(ARM_TF_PATH) $(ARM_TF_FLAGS) clean

[pascal-brand38]

Fixed ARM-TF build

[jforissier]

Why?

[pascal-brand38]

When we clean everything, we will clean both optee_os and optee_test. But the makefile of optee_test depends on the devkit in optee_os. So if optee_os is cleaned first, xtest-clean will fail.

[jforissier]

OK, but this will not prevent xtest-clean from failing the second time anyway, so optee_test/Makefile should also be fixed.

[pascal-brand38]

You're right :(

I propose to postpone xtest-clean to be fixed for another release, but to leave this optee-os-clean-common: xtest-clean for the time-being as it makes work 1 make all-clean at least

[jbech-linaro]

+1, do that as a follow up task.

[jforissier]

Agreed.

[jforissier]

Tested on HiKey. I identified some issues with make clean -- I think some changes to hikey.mk and possibly to the optee_test Makefile are needed, but this is not related to this PR. In any case, everything builds OK. So:
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)

[pascal-brand38]

#45 is cleaner