qemu_v8: Enable Rust examples build by default #717

b49020 · 2024-01-05T11:11:17Z

With no-std support it has significantly reduced time to build and test rust examples. So enable rust examples build by default for qemu_v8. Along with that add rust expect script to build repo to avoid check script duplication in OP-TEE rust SDK repo.

@DemesneGH Fyi..

b49020 · 2024-01-05T11:14:06Z

IBART failure seems unrelated to this PR, @jbech-linaro please have a look.

qemu-check.exp

rust.exp

b49020 · 2024-01-05T11:59:02Z

Addressed review comments, thanks.

DemesneGH · 2024-01-05T12:32:10Z

Acked-by: Yuan Zhuang <yuanz@apache.org>

jforissier

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

b49020 · 2024-01-05T13:16:24Z

Tags applied, thanks.

jforissier · 2024-01-05T15:19:36Z

@b49020 the QEMUv8 make COMPILE_S_USER=32 fails with:

     Running `/home/jerome/work/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/examples/acipher-rs/ta/target/release/build/ta-3b25c1a88446c8a1/build-script-build`
error: could not find native static library `utee`, perhaps an -L flag is missing?

error: could not compile `optee-utee-sys` due to previous error

Caused by:
  process didn't exit successfully: `rustc --crate-name optee_utee_sys --edition=2018 /home/jerome/work/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/optee-utee/optee-utee-sys/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=1 -C linker-plugin-lto -C metadata=d4ddde63eaa75a7a -C extra-filename=-d4ddde63eaa75a7a --out-dir /home/jerome/work/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/examples/acipher-rs/ta/target/aarch64-unknown-optee-trustzone/release/deps --target aarch64-unknown-optee-trustzone -C linker=aarch64-linux-gnu-ld -L dependency=/home/jerome/work/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/examples/acipher-rs/ta/target/aarch64-unknown-optee-trustzone/release/deps -L dependency=/home/jerome/work/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/examples/acipher-rs/ta/target/release/deps --extern libc=/home/jerome/work/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/examples/acipher-rs/ta/target/aarch64-unknown-optee-trustzone/release/deps/liblibc-ed330a60b78d74ed.rmeta -C link-arg=-e__ta_entry -C link-arg=-nostdlib -C link-arg=-Tta.lds -C link-arg=--sort-section=alignment -C link-arg=-pie -C link-arg=-Os -C link-dead-code --sysroot /home/jerome/.xargo -L /home/jerome/work/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/../../../optee_os/out/arm/export-ta_arm64/lib -l static=utee -l static=mbedtls` (exit status: 1)
warning: build failed, waiting for other jobs to finish...
error: build failed

Should OPTEE_RUST_ENABLE be set to y only for builds with 64-bit TAs?

qemu-check.exp

b49020 · 2024-01-08T08:02:05Z

@jforissier Rust supports 32-bit TAs [1] too but I have to make them work with OP-TEE build system too. I will add corresponding support prior to change in the PR.

[1] https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/no-std/.github/workflows/ci.yml#L90

jforissier · 2024-01-08T08:28:54Z

@b49020 excellent, thanks!

b49020 · 2024-01-11T13:54:34Z

@jforissier Now make COMPILE_S_USER=32 should pass on Qemuv8. Please have a look at the first patch.

jforissier

@b49020 thanks for the update!

A few comments below

Edit: Since I managed to run the Rust build an tests in a Docker container with the small changes mentioned below let's ignore the following
~~- With this PR, cargo is a new dependency, it should be added to https://optee.readthedocs.io/en/latest/building/prerequisites.html. I will take care of adding it to the optee_os CI Docker image.~~
- When building on my laptop, on first run of make -j10 check I get an error (printed several times):
"error: component download failed for cargo-x86_64-unknown-linux-gnu: could not rename downloaded file from '/home/jerome/.rustup/downloads/fc0055ac726cf9fe06dce3bfac393b2744e7ff0970766d02414c1c3e28d0eefa.partial' to '/home/jerome/.rustup/downloads/fc0055ac726cf9fe06dce3bfac393b2744e7ff0970766d02414c1c3e28d0eefa'"
I suspect something is being executed in parallel when it should only run once.
- When building in some Ubuntu 22.04 Docker image, I met the following error:
error[E0463]: can't find crate for std
|
= note: the aarch64-unknown-linux-gnu target may not be installed
= help: consider downloading the target with rustup target add aarch64-unknown-linux-gnu
Is it some other dependency I'm missing?

br-ext/package/optee_rust_examples_ext/Config.in

qemu-check.exp

jforissier · 2024-01-11T17:44:14Z

There is a OPTEE_RUST_ENABLE left over in common.mk. With that fixed and the following lines added to the Ubuntu 22.04 Dockerfile in https://optee.readthedocs.io/en/latest/building/prerequisites.html:

RUN curl -sSf https://sh.rustup.rs | sh -s -- -y
ENV PATH="$PATH:/root/.cargo/bin"
RUN rustup target add aarch64-unknown-linux-gnu arm-unknown-linux-gnueabihf

...the make -j$(nproc) check CHECK_TESTS=rust command passes.

However, make -j$(nproc) check CHECK_TESTS=rust COMPILE_S_USER=32 fails with:

[...]
buildroot login: root
# export LD_LIBRARY_PATH=/lib:/lib/arm-linux-gnueabihf
# acipher-rs 256 teststring
Error: Input data was of invalid format. (error code 0xffff0005)
# == end of /home/builder/optee/out/bin/serial0.log

b49020 · 2024-01-12T07:21:33Z

There is a OPTEE_RUST_ENABLE left over in common.mk.

Ah I missed that, it is the reason for your build and test issues as https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/no-std/setup.sh isn't executed to install specific rust nightly toolchain and dependencies (cargo etc.).

RUN curl -sSf https://sh.rustup.rs | sh -s -- -y
ENV PATH="$PATH:/root/.cargo/bin"
RUN rustup target add aarch64-unknown-linux-gnu arm-unknown-linux-gnueabihf

This won't be needed once setup.sh executes.

However, make -j$(nproc) check CHECK_TESTS=rust COMPILE_S_USER=32 fails with:

Can you retry this again as I have fixed OPTEE_RUST_ENABLE left over as we depend on a particular Rust compiler nightly release: https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/no-std/rust-toolchain.toml?

b49020 · 2024-01-12T08:24:49Z

Addressed comments.

b49020 · 2024-01-12T08:32:24Z

However, make -j$(nproc) check CHECK_TESTS=rust COMPILE_S_USER=32 fails with:

Can you retry this again as I have fixed OPTEE_RUST_ENABLE left over as we depend on a particular Rust compiler nightly release: https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/no-std/rust-toolchain.toml?

Also, please clean up the prior build too via:

rm -rf ../out-br/build/optee_rust_examples_ext-1.0/

jforissier · 2024-01-12T10:39:11Z

$ make -j10 run COMPILE_S_USER=32
[...]
Welcome to Buildroot, type root or test to login
buildroot login: test
$ acipher-rs 256 teststring
Error: Input data was of invalid format. (error code 0xffff0005)

D/TC:? 0 ldelf_syscall_open_bin:163 Lookup user TA ELF 057f4b66-bdab-11eb-96cf-33d6e41cc849 (REE)
D/TC:? 0 ldelf_syscall_open_bin:167 res=0
E/LD:  init_elf:511 Cannot parse ELF
E/TC:? 0 ldelf_init_with_ldelf:152 ldelf failed with res: 0xffff0005
D/TC:? 0 tee_ta_open_session:689 init session failed 0xffff0005

It looks like the TA ELF file has something that the OP-TEE loader doesn't like.

b49020 · 2024-01-12T10:48:14Z

It looks like the TA ELF file has something that the OP-TEE loader doesn't like.

Ah, I can reproduce this issue now. Somehow it passed earlier because my build environment wasn't cleaned properly. I will dig into this issue.

jforissier · 2024-01-12T10:56:03Z

I can see at least two fields in the ELF header that are unexpected. OP-TEE should probably accept "OS/ABI: ARM", but I'm not so sure about flags being zero.

build$ arm-linux-gnueabihf-readelf -h ../out-br/build/optee_rust_examples_ext-1.0/examples/acipher-rs/ta/target/arm-unknown-linux-gnueabihf/release/stripped_ta
ELF Header:
Magic: 7f 45 4c 46 01 01 01 61 00 00 00 00 00 00 00 00
Class: ELF32
Data: 2's complement, little endian
Version: 1 (current)
OS/ABI: ARM
ABI Version: 0
Type: DYN (Position-Independent Executable file)
Machine: ARM
Version: 0x1
Entry point address: 0x3340
Start of program headers: 52 (bytes into file)
Start of section headers: 145660 (bytes into file)
Flags: 0x0
Size of this header: 52 (bytes)
Size of program headers: 32 (bytes)
Number of program headers: 4
Size of section headers: 40 (bytes)
Number of section headers: 19
Section header string table index: 18

build$ $ arm-linux-gnueabihf-readelf -h ./build/optee_examples_ext-1.0/acipher/ta/out/a734eed9-d6a1-4244-aa50-7c99719e7b7b.stripped.elf
ELF Header:
Magic: 7f 45 4c 46 01 01 01 00 00 00 00 00 00 00 00 00
Class: ELF32
Data: 2's complement, little endian
Version: 1 (current)
OS/ABI: UNIX - System V
ABI Version: 0
Type: DYN (Position-Independent Executable file)
Machine: ARM
Version: 0x1
Entry point address: 0x28c
Start of program headers: 52 (bytes into file)
Start of section headers: 70944 (bytes into file)
Flags: 0x5000400, Version5 EABI, hard-float ABI
Size of this header: 52 (bytes)
Size of program headers: 32 (bytes)
Number of program headers: 5
Size of section headers: 40 (bytes)
Number of section headers: 19
Section header string table index: 18

b49020 · 2024-01-15T09:23:29Z

@jforissier

I can see at least two fields in the ELF header that are unexpected. OP-TEE should probably accept "OS/ABI: ARM", but I'm not so sure about flags being zero.

As per ELF manpage [1], the flags field value is dependent on EI_OSABI which is essentially EF_ARM_EABI_UNKNOWN in case of ELFOSABI_ARM. Also, I have tried different ways to configure Rust 32-bit TAs in no-std mode but I still see the same OS ABI being used. Hence, I have come up with this PR: OP-TEE/optee_os#6605, please have a look.

[1] https://man7.org/linux/man-pages/man5/elf.5.html

jforissier · 2024-01-15T11:01:14Z

With OP-TEE/optee_os#6605 the TA panics.

E/TC:? 0 User mode prefetch-abort at address 0x40038340 (read permission fault)
E/TC:? 0  esr 0x8200000f  ttbr0 0x400000e1b2000   ttbr1 0x00000000   cidr 0x0
E/TC:? 0  cpu #0          cpsr 0x00000110
E/TC:? 0  x0  0000000000000000 x1  000000000009d870
E/TC:? 0  x2  0000000040015f80 x3  0000000000000000
E/TC:? 0  x4  0000000000000000 x5  0000000000000000
E/TC:? 0  x6  0000000000000000 x7  0000000000000000
E/TC:? 0  x8  0000000000000000 x9  0000000000000000
E/TC:? 0  x10 0000000000000000 x11 0000000000000000
E/TC:? 0  x12 0000000000000000 x13 0000000040015f80
E/TC:? 0  x14 0000000000000000 x15 0000000000000000
E/TC:? 0  x16 0000000000000000 x17 0000000000000000
E/TC:? 0  x18 0000000000000000 x19 0000000000000000
E/TC:? 0  x20 0000000000000000 x21 0000000000000000
E/TC:? 0  x22 0000000000000000 x23 0000000000000000
E/TC:? 0  x24 0000000000000000 x25 0000000000000000
E/TC:? 0  x26 0000000000000000 x27 0000000000000000
E/TC:? 0  x28 0000000000000000 x29 0000000000000000
E/TC:? 0  x30 0000000000000000 elr 0000000040038340
E/TC:? 0  sp_el0 0000000040015f80
E/LD:  Status of TA 057f4b66-bdab-11eb-96cf-33d6e41cc849
E/LD:   arch: arm
E/LD:  region  0: va 0x40005000 pa 0x0e32c000 size 0x002000 flags rw-s (ldelf)
E/LD:  region  1: va 0x40007000 pa 0x0e32e000 size 0x008000 flags r-xs (ldelf)
E/LD:  region  2: va 0x4000f000 pa 0x0e336000 size 0x001000 flags rw-s (ldelf)
E/LD:  region  3: va 0x40010000 pa 0x0e337000 size 0x004000 flags rw-s (ldelf)
E/LD:  region  4: va 0x40014000 pa 0x0e33b000 size 0x001000 flags r--s
E/LD:  region  5: va 0x40015000 pa 0x0e35c000 size 0x001000 flags rw-s (stack)
E/LD:  region  6: va 0x40035000 pa 0x00010000 size 0x020000 flags rwxs [0]
E/LD:   [0] 057f4b66-bdab-11eb-96cf-33d6e41cc849 @ 0x40035000
E/LD:  Call stack:
E/LD:   0x40038340
E/LD:   0x00000000
D/TC:? 0 user_ta_enter:201 tee_user_ta_enter: TA panicked with code 0xdeadbeef
D/TC:? 0 release_ta_ctx:663 Releasing panicked TA ctx
D/TC:? 0 tee_ta_close_session:463 csess 0x9b91f860 id 2
D/TC:? 0 tee_ta_close_session:482 Destroy session
D/TC:? 0 destroy_context:321 Destroy TA ctx (0x9b91f800)
E/TC:? 0 tee_ta_open_session:738 Failed for TA 057f4b66-bdab-11eb-96cf-33d6e41cc849. Return error 0xffff3024

The Rust environment doesn't produce a file (or symlink) called 057f4b66-bdab-11eb-96cf-33d6e41cc849.elf so it is not convenient to run symbolize.py. Anyways, the rwxs permissions for region 6 look suspicious (writable and executable at the same time is forbidden by some config flag I think?)

b49020 · 2024-01-15T12:01:37Z

The Rust environment doesn't produce a file (or symlink) called 057f4b66-bdab-11eb-96cf-33d6e41cc849.elf so it is not convenient to run symbolize.py.

I hope debugging Rust TAs situation would improve further in future since we also have to map symbols to Rust code as well. However, the first step that I am trying to take here is enable 32-bit Rust TAs to run.

Anyways, the rwxs permissions for region 6 look suspicious (writable and executable at the same time is forbidden by some config flag I think?)

Thanks for catching that, the fix is already available here: apache/incubator-teaclave-trustzone-sdk#118 to be merged.

jforissier

@b49020 many thanks for doing this and addressing the various issues. One minor comment below. With that fixed:

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_armv8a)

qemu-check.exp

First of all since Rust examples have been tested for Arm targets, so just enable them for Arm platforms only. Further to support different build configurations for host applications and TAs, the Rust examples build have been generalized. So now we only need to define following environment variables to build Rust examples: - TARGET_HOST: Rust toolchain target for host applications. - TARGET_TA: Rust toolchain target for TAs. - CROSS_COMPILE_HOST: GCC cross compiler path for host applications. - CROSS_COMPILE_TA: GCC cross compiler path for TAs - TA_DEV_KIT_DIR: Path to OP-TEE TA development kit directory. - OPTEE_CLIENT_EXPORT: Path to OP-TEE client export directory. Along with that the config option to enable Rust examples is renamed: s/OPTEE_RUST_ENABLE/RUST_ENABLE/. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_armv8a) Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

With no-std support it has significantly reduced time to build and test rust examples. So enable rust examples build by default for qemu_v8. Along with that add rust expect script to build repo to avoid check script duplication in OP-TEE rust SDK repo. Link: https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/no-std/ci/qemu-check.exp Acked-by: Yuan Zhuang <yuanz@apache.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_armv8a) Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

b49020 · 2024-01-16T09:58:34Z

Addressed comments and tags applied, thanks.

Now that [1] is merged, Rust tests are enabled by default for QEMUv8 and there is no need for a separate Rust job in CI, so remove it. On the other hand, a couple of fixes are needed: - Update PATH so that the cargo command (which is installed locally during the build of the Rust SDK) can be found. - Disable Rust in the BTI+MTE+PAC test because the Rust examples fail to build with the supplied toolchain: /usr/local/bin/../lib/gcc/aarch64-unknown-linux-uclibc/12.2.0/../../../../aarch64-unknown-linux-uclibc/bin/ld.bfd: /tmp/rustcmQty55/libcompiler_builtins-76fca0633b54e12b.rlib(45c91108d938afe8-cpu_model.o): in function `init_have_lse_atomics': /cargo/registry/src/index.crates.io-6f17d22bba15001f/compiler_builtins-0.1.101/./lib/builtins/cpu_model.c:1075: undefined reference to `getauxval' ... Link: OP-TEE/build#717 [1] Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

Now that [1] is merged, Rust tests are enabled by default for QEMUv8 and there is no need for a separate Rust job in CI, so remove it. On the other hand, a couple of fixes are needed: - Update PATH so that the cargo command (which is installed locally during the build of the Rust SDK) can be found. - Disable Rust in the BTI+MTE+PAC test because the Rust examples fail to build with the supplied toolchain: /usr/local/bin/../lib/gcc/aarch64-unknown-linux-uclibc/12.2.0/../../../../aarch64-unknown-linux-uclibc/bin/ld.bfd: /tmp/rustcmQty55/libcompiler_builtins-76fca0633b54e12b.rlib(45c91108d938afe8-cpu_model.o): in function `init_have_lse_atomics': /cargo/registry/src/index.crates.io-6f17d22bba15001f/compiler_builtins-0.1.101/./lib/builtins/cpu_model.c:1075: undefined reference to `getauxval' ... - Also disable Rust in the test that enables ftrace, because the signature_verification-rs programm just hangs in this configuration. Link: OP-TEE/build#717 [1] Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

Now that [1] is merged, Rust tests are enabled by default for QEMUv8 and there is no need for a separate Rust job in CI, so remove it. On the other hand, a couple of fixes are needed: - Update PATH so that the cargo command (which is installed locally during the build of the Rust SDK) can be found. - Disable Rust in the BTI+MTE+PAC test because the Rust examples fail to build with the supplied toolchain: /usr/local/bin/../lib/gcc/aarch64-unknown-linux-uclibc/12.2.0/../../../../aarch64-unknown-linux-uclibc/bin/ld.bfd: /tmp/rustcmQty55/libcompiler_builtins-76fca0633b54e12b.rlib(45c91108d938afe8-cpu_model.o): in function `init_have_lse_atomics': /cargo/registry/src/index.crates.io-6f17d22bba15001f/compiler_builtins-0.1.101/./lib/builtins/cpu_model.c:1075: undefined reference to `getauxval' ... - Also disable Rust in the test that enables ftrace, because the signature_verification-rs command just hangs in this configuration. Link: OP-TEE/build#717 [1] Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

Now that [1] is merged, Rust tests are enabled by default for QEMUv8 and there is no need for a separate Rust job in CI, so remove it. On the other hand, a couple of fixes are needed: - Update PATH so that the cargo command (which is installed locally during the build of the Rust SDK) can be found. - Disable Rust in the BTI+MTE+PAC test because the Rust examples fail to build with the supplied toolchain: /usr/local/bin/../lib/gcc/aarch64-unknown-linux-uclibc/12.2.0/../../../../aarch64-unknown-linux-uclibc/bin/ld.bfd: /tmp/rustcmQty55/libcompiler_builtins-76fca0633b54e12b.rlib(45c91108d938afe8-cpu_model.o): in function `init_have_lse_atomics': /cargo/registry/src/index.crates.io-6f17d22bba15001f/compiler_builtins-0.1.101/./lib/builtins/cpu_model.c:1075: undefined reference to `getauxval' ... - Also disable Rust in the test that enables ftrace, because the signature_verification-rs command just hangs in this configuration. Link: OP-TEE/build#717 [1] Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

jforissier reviewed Jan 5, 2024

View reviewed changes

qemu-check.exp Outdated Show resolved Hide resolved

qemu-check.exp Outdated Show resolved Hide resolved

rust.exp Show resolved Hide resolved

b49020 force-pushed the master branch from d9b7624 to fa7b4e1 Compare January 5, 2024 11:58

jforissier reviewed Jan 5, 2024

View reviewed changes

b49020 force-pushed the master branch from fa7b4e1 to 34f0b1d Compare January 5, 2024 13:15

jforissier reviewed Jan 5, 2024

View reviewed changes

qemu-check.exp Outdated Show resolved Hide resolved

b49020 force-pushed the master branch from 34f0b1d to ca8b7ee Compare January 11, 2024 13:49

jforissier requested changes Jan 11, 2024

View reviewed changes

b49020 force-pushed the master branch from ca8b7ee to 46c30e0 Compare January 12, 2024 07:20

b49020 force-pushed the master branch from 46c30e0 to a2f9f82 Compare January 12, 2024 08:22

b49020 requested a review from jforissier January 12, 2024 09:11

jforissier approved these changes Jan 15, 2024

View reviewed changes

qemu-check.exp Outdated Show resolved Hide resolved

b49020 mentioned this pull request Jan 15, 2024

examples: 32-bit TAs: Fix runtime abort apache/incubator-teaclave-trustzone-sdk#118

Merged

b49020 added 2 commits January 16, 2024 15:25

b49020 force-pushed the master branch from a2f9f82 to bb22a6d Compare January 16, 2024 09:57

b49020 mentioned this pull request Jan 16, 2024

Update CHANGELOG for 4.1.0 OP-TEE/optee_os#6574

Merged

jforissier merged commit e742dc8 into OP-TEE:master Jan 19, 2024
1 check passed

jforissier mentioned this pull request Jan 19, 2024

caam sm2 OP-TEE/optee_os#6624

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qemu_v8: Enable Rust examples build by default #717

qemu_v8: Enable Rust examples build by default #717

b49020 commented Jan 5, 2024

b49020 commented Jan 5, 2024

b49020 commented Jan 5, 2024

DemesneGH commented Jan 5, 2024

jforissier left a comment

b49020 commented Jan 5, 2024

jforissier commented Jan 5, 2024

b49020 commented Jan 8, 2024

jforissier commented Jan 8, 2024

b49020 commented Jan 11, 2024

jforissier left a comment •

edited

Loading

jforissier commented Jan 11, 2024 •

edited

Loading

b49020 commented Jan 12, 2024

b49020 commented Jan 12, 2024

b49020 commented Jan 12, 2024

jforissier commented Jan 12, 2024

b49020 commented Jan 12, 2024

jforissier commented Jan 12, 2024

b49020 commented Jan 15, 2024

jforissier commented Jan 15, 2024

b49020 commented Jan 15, 2024

jforissier left a comment

b49020 commented Jan 16, 2024

qemu_v8: Enable Rust examples build by default #717

qemu_v8: Enable Rust examples build by default #717

Conversation

b49020 commented Jan 5, 2024

b49020 commented Jan 5, 2024

b49020 commented Jan 5, 2024

DemesneGH commented Jan 5, 2024

jforissier left a comment

Choose a reason for hiding this comment

b49020 commented Jan 5, 2024

jforissier commented Jan 5, 2024

b49020 commented Jan 8, 2024

jforissier commented Jan 8, 2024

b49020 commented Jan 11, 2024

jforissier left a comment • edited Loading

Choose a reason for hiding this comment

jforissier commented Jan 11, 2024 • edited Loading

b49020 commented Jan 12, 2024

b49020 commented Jan 12, 2024

b49020 commented Jan 12, 2024

jforissier commented Jan 12, 2024

b49020 commented Jan 12, 2024

jforissier commented Jan 12, 2024

b49020 commented Jan 15, 2024

jforissier commented Jan 15, 2024

b49020 commented Jan 15, 2024

jforissier left a comment

Choose a reason for hiding this comment

b49020 commented Jan 16, 2024

jforissier left a comment •

edited

Loading

jforissier commented Jan 11, 2024 •

edited

Loading