core: fixup of transfer list entry overriding

[raymo200915]

Expand the data size of DTB transfer list entry to the max allocable size to reserve sufficient space for new nodes.
This fixes a potential issue that the amended DTB transfer entry overrides other entries followed by, when inserting new nodes.

[raymo200915]

All comments have been addressed.

[raymo200915]

Separated commit for DT changes.
Squashed fixup commits.
All comments have been addressed.

[raymo200915]

CI / make check (QEMUv8, BTI+MTE+PAC) (pull_request) failed due to a connection timeout when downloading the toolchain, looks not related to this PR.

Downloading arm-gnu-toolchain-11.3.rel1-x86_64-arm-none-linux-gnueabihf ...
Downloading arm-gnu-toolchain-11.3.rel1-x86_64-aarch64-none-linux-gnu ...
curl: (56) OpenSSL SSL_read: Connection timed out, errno 110
Download failed
make: *** [toolchain.mk:68: aarch64] Error 1
Error: Process completed with exit code 2.

[jforissier]

@raymo200915 hopefully a transient network issue, I have restarted the job, thanks for the heads up

[etienne-lms]

For commit "core: fixup of transfer list entry overriding":
commit message should also tell that when transfer list is used, the FDT max size is given by the TL max_size field, not by the configuration switch CFG_DTB_MAX_SIZE.

[raymo200915]

For commit "core: fixup of transfer list entry overriding":
commit message should also tell that when transfer list is used, the FDT max size is given by the TL max_size field, not by the > configuration switch CFG_DTB_MAX_SIZE.

Fixed.

[raymo200915]

Updated commit message of "core: fixup of transfer list entry overriding".
Addressed review comments.

[etienne-lms]

Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com> (for bith commits) with below comments addressed for the commit message on commit "core: fixup of transfer list entry overriding":

Header line: "core: arm: fixup of transfer list entry overriding"

Since this is a fix, could you add a Fixes: tag related to the TL integration commit?

Swap the 2 last paragraph. The last one refers to the 1st one:

 Expand the data size of DTB transfer list entry to the max allocable
 size to reserve sufficient space for new nodes.
+This fixes a potential issue that the amended DTB transfer entry
+overrides other entries followed by, when inserting new nodes.
+
 When CFG_TRANSFER_LIST is enabled, instead of CFG_DTB_MAX_SIZE,
 the DTB max size will be given by a calculation of the remaining space
 in the transfer list mapped memory.
-This fixes a potential issue that the amended DTB transfer entry
-overrides other entries followed by, when inserting new nodes.

Thanks

[raymo200915]

Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com> (for bith commits) with below comments addressed for the commit message on commit "core: fixup of transfer list entry overriding":

Header line: "core: arm: fixup of transfer list entry overriding"

Since this is a fix, could you add a Fixes: tag related to the TL integration commit?

Swap the 2 last paragraph. The last one refers to the 1st one:

 Expand the data size of DTB transfer list entry to the max allocable
 size to reserve sufficient space for new nodes.
+This fixes a potential issue that the amended DTB transfer entry
+overrides other entries followed by, when inserting new nodes.
+
 When CFG_TRANSFER_LIST is enabled, instead of CFG_DTB_MAX_SIZE,
 the DTB max size will be given by a calculation of the remaining space
 in the transfer list mapped memory.
-This fixes a potential issue that the amended DTB transfer entry
-overrides other entries followed by, when inserting new nodes.

Thanks

Done. Thanks @etienne-lms

[raymo200915]

Commit message updated.
Review tags added.

[jenswi-linaro]

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

[raymo200915]

Thanks @jenswi-linaro , review tags added.