Enable .NET analyzers for all projects (#1414)

* Enable .NET analyzers for all projects * fix all new warnings, mostly security and perf
OPCFoundation · Jun 5, 2021 · 9923141 · 9923141
1 parent 8406716
commit 9923141
Show file tree

Hide file tree

Showing 14 changed files with 30 additions and 20 deletions.
diff --git a/Libraries/Opc.Ua.Client.ComplexTypes/ComplexTypeSystem.cs b/Libraries/Opc.Ua.Client.ComplexTypes/ComplexTypeSystem.cs
@@ -276,7 +276,7 @@ bool fullTypeList
             var typeSystem = await m_session.LoadDataTypeSystem().ConfigureAwait(false);
 
             // sort dictionaries with import dependencies to the end of the list
-            var sortedTypeSystem = typeSystem.OrderBy(t => t.Value.TypeDictionary?.Import?.Count()).ToList();
+            var sortedTypeSystem = typeSystem.OrderBy(t => t.Value.TypeDictionary?.Import?.Length).ToList();
 
             bool allTypesLoaded = true;
 

diff --git a/Libraries/Opc.Ua.Client.ComplexTypes/TypeBuilder/AttributeExtensions.cs b/Libraries/Opc.Ua.Client.ComplexTypes/TypeBuilder/AttributeExtensions.cs
@@ -87,7 +87,7 @@ public static void DataMemberAttribute(this PropertyBuilder typeBuilder, string
             ConstructorInfo ctorInfo = attributeType.GetConstructor(Type.EmptyTypes);
             CustomAttributeBuilder builder = new CustomAttributeBuilder(
                 ctorInfo,
-                new object[0],  // constructor arguments
+                Array.Empty<object>(),  // constructor arguments
                 new[]           // properties to assign
                 {
                     attributeType.GetProperty("DefaultEncodingId"),
@@ -117,7 +117,7 @@ ExpandedNodeId xmlEncodingId
             ConstructorInfo ctorInfo = attributeType.GetConstructor(Type.EmptyTypes);
             CustomAttributeBuilder builder = new CustomAttributeBuilder(
                 ctorInfo,
-                new object[0],  // constructor arguments
+                Array.Empty<object>(),  // constructor arguments
                 new[]           // properties to assign
                 {
                     attributeType.GetProperty("ComplexTypeId"),
@@ -144,7 +144,7 @@ ExpandedNodeId xmlEncodingId
             ConstructorInfo ctorInfo = attributeType.GetConstructor(Type.EmptyTypes);
             CustomAttributeBuilder builder = new CustomAttributeBuilder(
                 ctorInfo,
-                new object[0],  // constructor arguments
+                Array.Empty<object>(),  // constructor arguments
                 new[]           // properties to assign
                 {
                     attributeType.GetProperty("ValueRank"),
@@ -170,7 +170,7 @@ public static void EnumMemberAttribute(this FieldBuilder typeBuilder, string Nam
             ConstructorInfo ctorInfo = attributeType.GetConstructor(Type.EmptyTypes);
             CustomAttributeBuilder builder = new CustomAttributeBuilder(
                 ctorInfo,
-                new object[0],  // constructor arguments
+                Array.Empty<object>(),  // constructor arguments
                 new[]           // properties to assign
                 {
                     attributeType.GetProperty("Value")
@@ -193,7 +193,7 @@ private static CustomAttributeBuilder DataMemberAttributeBuilder(string name, bo
             ConstructorInfo ctorInfo = attributeType.GetConstructor(Type.EmptyTypes);
             CustomAttributeBuilder builder = new CustomAttributeBuilder(
                 ctorInfo,
-                new object[0],  // constructor arguments
+                Array.Empty<object>(),  // constructor arguments
                 new[]           // properties to assign
                 {
                     attributeType.GetProperty("Name"),
@@ -218,7 +218,7 @@ private static CustomAttributeBuilder DataContractAttributeBuilder(string Namesp
             ConstructorInfo ctorInfo = attributeType.GetConstructor(Type.EmptyTypes);
             CustomAttributeBuilder builder = new CustomAttributeBuilder(
                 ctorInfo,
-                new object[0],  // constructor arguments
+                Array.Empty<object>(),  // constructor arguments
                 new[]           // properties to assign
                 {
                     attributeType.GetProperty("Namespace")

diff --git a/Libraries/Opc.Ua.Client.ComplexTypes/Types/BaseComplexType.cs b/Libraries/Opc.Ua.Client.ComplexTypes/Types/BaseComplexType.cs
@@ -278,7 +278,7 @@ private void AddSeparator(StringBuilder body)
         {
             if (body.Length == 0)
             {
-                body.Append("{");
+                body.Append('{');
             }
             else
             {
@@ -302,17 +302,17 @@ private void AddSeparator(StringBuilder body)
             {
                 bool first = true;
                 var enumerable = value as IEnumerable;
-                body.Append("[");
+                body.Append('[');
                 foreach (var item in enumerable)
                 {
                     if (!first)
                     {
-                        body.Append(",");
+                        body.Append(',');
                     }
                     AppendPropertyValue(formatProvider, body, item);
                     first = false;
                 }
-                body.Append("]");
+                body.Append(']');
             }
             else
             {

diff --git a/Libraries/Opc.Ua.Client.ComplexTypes/Types/OptionalFieldsComplexType.cs b/Libraries/Opc.Ua.Client.ComplexTypes/Types/OptionalFieldsComplexType.cs
@@ -202,7 +202,7 @@ public override string ToString(string format, IFormatProvider formatProvider)
 
                 if (body.Length > 0)
                 {
-                    body.Append("}");
+                    body.Append('}');
                     return body.ToString();
                 }
 

diff --git a/Libraries/Opc.Ua.Client.ComplexTypes/Types/UnionComplexType.cs b/Libraries/Opc.Ua.Client.ComplexTypes/Types/UnionComplexType.cs
@@ -215,7 +215,7 @@ public override string ToString(string format, IFormatProvider formatProvider)
 
                 if (body.Length > 0)
                 {
-                    body.Append("}");
+                    body.Append('}');
                     return body.ToString();
                 }
 

diff --git a/Libraries/Opc.Ua.Gds.Server.Common/ApplicationsDatabaseBase.cs b/Libraries/Opc.Ua.Gds.Server.Common/ApplicationsDatabaseBase.cs
@@ -1,4 +1,4 @@
-/* ========================================================================
+/* ========================================================================
  * Copyright (c) 2005-2020 The OPC Foundation, Inc. All rights reserved.
  *
  * OPC Foundation MIT License 1.00
@@ -494,7 +494,7 @@ private static List<string> Parse(string pattern)
                         ii++;
                     }
 
-                    buffer.Append("]");
+                    buffer.Append(']');
                     tokens.Add(buffer.ToString());
                     buffer.Length = 0;
 

diff --git a/Libraries/Opc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs b/Libraries/Opc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs
@@ -681,7 +681,7 @@ private string GetSubjectName(ApplicationRecordDataType application, Certificate
             {
                 if (builder.Length > 0)
                 {
-                    builder.Append(",");
+                    builder.Append(',');
                 }
 
                 if (field.StartsWith("CN=", StringComparison.Ordinal))

diff --git a/Stack/Opc.Ua.Bindings.Https/Stack/Https/HttpsTransportListener.cs b/Stack/Opc.Ua.Bindings.Https/Stack/Https/HttpsTransportListener.cs
@@ -234,7 +234,7 @@ public void Start()
             httpsOptions.CheckCertificateRevocation = false;
             httpsOptions.ClientCertificateMode = ClientCertificateMode.NoCertificate;
             httpsOptions.ServerCertificate = m_serverCert;
-            httpsOptions.SslProtocols = SslProtocols.Tls | SslProtocols.Tls11 | SslProtocols.Tls12;
+            httpsOptions.SslProtocols = SslProtocols.None;
             m_hostBuilder.UseKestrel(options => {
                 options.Listen(IPAddress.Any, m_uri.Port, listenOptions => {
                     // listenOptions.NoDelay = true;
@@ -342,7 +342,11 @@ public async Task SendAsync(HttpContext context)
                 context.Response.ContentLength = response.Length;
                 context.Response.ContentType = context.Request.ContentType;
                 context.Response.StatusCode = (int)HttpStatusCode.OK;
+#if NETSTANDARD2_1
+                await context.Response.Body.WriteAsync(response.AsMemory(0, response.Length)).ConfigureAwait(false);
+#else
                 await context.Response.Body.WriteAsync(response, 0, response.Length).ConfigureAwait(false);
+#endif
             }
             catch (Exception e)
             {

diff --git a/Tests/Opc.Ua.Core.Tests/Security/Certificates/CertificateValidatorTest.cs b/Tests/Opc.Ua.Core.Tests/Security/Certificates/CertificateValidatorTest.cs
@@ -1179,7 +1179,7 @@ public async Task TestAutoAccept(bool trusted, bool autoAccept)
             // override the autoaccept flag, but do not approve
             certValidator = validator.Update();
             certValidator.AutoAcceptUntrustedCertificates = autoAccept;
-            approver = new CertValidationApprover(new StatusCode[] { });
+            approver = new CertValidationApprover(Array.Empty<StatusCode>());
             certValidator.CertificateValidation += approver.OnCertificateValidation;
             if (trusted)
             {

diff --git a/Tests/Opc.Ua.Core.Tests/Types/Utils/UtilTests.cs b/Tests/Opc.Ua.Core.Tests/Types/Utils/UtilTests.cs
@@ -165,6 +165,10 @@ public void RelativePathParseAlphanumericWithNamespaceIndexStringPath()
         /// exponential entity expansion in this version of .NET.
         /// </summary>
         [Test]
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Security", "CA3075:Insecure DTD processing in XML",
+            Justification =
+                "Validate that XmlDocument DtdProcessing is protected against" +
+                "exponential entity expansion in this version of .NET.")]
         public void ExponentialEntityExpansionProcessing()
         {
             StringBuilder xmlEEXX = new StringBuilder();

diff --git a/Tests/Opc.Ua.PubSub.Tests/Transport/UdpClientCreatorTests.cs b/Tests/Opc.Ua.PubSub.Tests/Transport/UdpClientCreatorTests.cs
@@ -203,7 +203,7 @@ private string ReplaceLastIpByte(string ipAddress, string lastIpByte)
                 if (isValidIP)
                 {
                     byte[] ipAddressBytes = validIp.GetAddressBytes();
-                    for (int pos = 0; pos < ipAddressBytes.Count() - 1; pos++)
+                    for (int pos = 0; pos < ipAddressBytes.Length - 1; pos++)
                     {
                         newIPAddress += string.Format("{0}.", ipAddressBytes[pos]);
                     }

diff --git a/Tests/Opc.Ua.PubSub.Tests/Transport/UdpPubSubConnectionTests.cs b/Tests/Opc.Ua.PubSub.Tests/Transport/UdpPubSubConnectionTests.cs
@@ -246,7 +246,7 @@ private static IPAddress GetFirstNicLastIPByteChanged(byte lastIpByte)
                 if (isValidIP)
                 {
                     byte[] ipAddressBytes = validIp.GetAddressBytes();
-                    ipAddressBytes[ipAddressBytes.Count() - 1] = lastIpByte;
+                    ipAddressBytes[ipAddressBytes.Length - 1] = lastIpByte;
                     return new IPAddress(ipAddressBytes);
                 }
             }

diff --git a/UA Core Library.sln b/UA Core Library.sln
@@ -28,6 +28,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		.editorconfig = .editorconfig
 		azure-pipelines-preview.yml = azure-pipelines-preview.yml
 		azure-pipelines.yml = azure-pipelines.yml
+		Tests\codecoverage.cmd = Tests\codecoverage.cmd
 		common.props = common.props
 		Directory.Build.props = Directory.Build.props
 		lgtm.yml = lgtm.yml

diff --git a/common.props b/common.props
@@ -11,6 +11,7 @@
     <NeutralLanguage>en-US</NeutralLanguage>
     <HighEntropyVA>true</HighEntropyVA>
     <IsPackable>false</IsPackable>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <!--TODO <GenerateDocumentationFile>true</GenerateDocumentationFile>-->
   </PropertyGroup>