-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable .NET analyzers for all projects #1414
Conversation
mregen
commented
May 30, 2021
- fix new warnings
@@ -234,7 +234,7 @@ public void Start() | |||
httpsOptions.CheckCertificateRevocation = false; | |||
httpsOptions.ClientCertificateMode = ClientCertificateMode.NoCertificate; | |||
httpsOptions.ServerCertificate = m_serverCert; | |||
httpsOptions.SslProtocols = SslProtocols.Tls | SslProtocols.Tls11 | SslProtocols.Tls12; | |||
httpsOptions.SslProtocols = SslProtocols.None; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a functional change from Tlx|Tls11|Tls12 to None, what is the rational behind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that setting "SslProtocols = SslProtocols.None" will allow the OS to chose the best protocol to use.
But maybe Martin can confirm...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, Tls 1.1 etc should not be used anymore