Skip to content

Commit

Permalink
Updates for getIssuer(s) in the Certificate Validator class (#1632)
Browse files Browse the repository at this point in the history
- Adapted getIssuer and getIssuers so that all findings get aggregated for later processing in the validation methods.
- Ensured that other methods calling getIssuer(s) will experience unchanged behavior
- Adapted unit tests
  • Loading branch information
ThomasNehring committed Jan 14, 2022
1 parent 6747b47 commit dd6f4a4
Show file tree
Hide file tree
Showing 4 changed files with 579 additions and 52 deletions.
1 change: 1 addition & 0 deletions Libraries/Opc.Ua.Configuration/ApplicationInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,7 @@ public void OnCertificateValidation(object sender, CertificateValidationEventArg
new StatusCode[] {
StatusCodes.BadCertificateUntrusted,
StatusCodes.BadCertificateTimeInvalid,
StatusCodes.BadCertificateIssuerTimeInvalid,
StatusCodes.BadCertificateHostNameInvalid,
StatusCodes.BadCertificateRevocationUnknown,
StatusCodes.BadCertificateIssuerRevocationUnknown,
Expand Down
1 change: 1 addition & 0 deletions Libraries/Opc.Ua.Server/Server/StandardServer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ protected bool IsSecurityError(StatusCode error)
case StatusCodes.BadCertificateIssuerRevocationUnknown:
case StatusCodes.BadCertificateInvalid:
case StatusCodes.BadCertificateHostNameInvalid:
case StatusCodes.BadCertificatePolicyCheckFailed:
case StatusCodes.BadApplicationSignatureInvalid:
{
return true;
Expand Down

0 comments on commit dd6f4a4

Please sign in to comment.