Updates for getIssuer(s) in the Certificate Validator class

[ThomasNehring]

• Adapted getIssuer and getIssuers so that all findings get aggregated for later processing in the validation methods.
• Ensured that other methods calling getIssuer(s) will experience unchanged behavior
• Adapted unit tests

[lgtm-com]

This pull request introduces 2 alerts when merging 5588555 into 58bac5a - view on LGTM.com

new alerts:

• 1 for Container contents are never accessed
• 1 for Useless assignment to local variable

[mregen]

@ThomasNehring please merge master again, I can't push the merged version becuase some github actions were updated..

here is the final version you could merge: https://github.com/mregen/UA-.NetStandardLibrary/tree/local/get_issuer_noexception

[mregen]

can be merged once final version is merged: https://github.com/mregen/UA-.NetStandardLibrary/tree/local/get_issuer_noexception

[mregen]

@ThomasNehring testing CTT, found a few unrelated issues, so regarding these improvements looks all good.
However, test 02 causes the specific tests to fail with BadCertificateInvalid instead of BadIssuerRevocationUnknown.
The root cause is that X509Chain doesn't accept the root cert created in the CTT, so the chain is incomplete.
Now investigating why a cert chain used in CTT is not accepted in windows, It may have to do with bad serial number or SKI being invalid.

[mregen]

CTT passes once proper root CA cert is created by CTT --> https://mantis.opcfoundation.org/view.php?id=7509

[lgtm-com]

This pull request introduces 2 alerts and fixes 1 when merging b4c1467 into 9188dcf - view on LGTM.com

new alerts:

• 1 for Container contents are never accessed
• 1 for Useless assignment to local variable

fixed alerts:

• 1 for Missing Dispose call on local IDisposable

[lgtm-com]

This pull request introduces 2 alerts and fixes 1 when merging 6001d08 into 9188dcf - view on LGTM.com

new alerts:

• 1 for Container contents are never accessed
• 1 for Useless assignment to local variable

fixed alerts:

• 1 for Missing Dispose call on local IDisposable

[mregen]

great work 🚀 @ThomasNehring. This looks now good - during CTT testing I ran into some other issues that may have been unrelated but are now creeping in with this PR. But most were running the cert tests...

[lgtm-com]

This pull request introduces 2 alerts and fixes 1 when merging b57588d into b41fb36 - view on LGTM.com

new alerts:

• 1 for Container contents are never accessed
• 1 for Useless assignment to local variable

fixed alerts:

• 1 for Missing Dispose call on local IDisposable

[codecov]

Codecov Report

Merging #1632 (6747b47) into master (6747b47) will not change coverage.
The diff coverage is n/a.

❗ Current head 6747b47 differs from pull request most recent head 7890cf6. Consider uploading reports for the commit 7890cf6 to get more accurate results

@@           Coverage Diff           @@
##           master    #1632   +/-   ##
=======================================
  Coverage   53.88%   53.88%           
=======================================
  Files         319      319           
  Lines       57776    57776           
=======================================
  Hits        31134    31134           
  Misses      26642    26642           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6747b47...7890cf6. Read the comment docs.

[mregen]

Hi @ThomasNehring , the code works as expected on windows/macOS, but apparently there is still an issue with linux cert validation. I'm debugging it but to no success yet. Please stay tuned...

[lgtm-com]

This pull request introduces 2 alerts and fixes 1 when merging 0f3d6e4 into fa6099b - view on LGTM.com

new alerts:

• 1 for Container contents are never accessed
• 1 for Useless assignment to local variable

fixed alerts:

• 1 for Missing Dispose call on local IDisposable

[mregen]

Hi @ThomasNehring , #1665 fixes the linux cert issue, once merged, should be ready to go...

[mregen]

a couple of CTT fixes ended up here which are unrelated -- will be removed

[lgtm-com]

This pull request introduces 5 alerts and fixes 1 when merging d295539 into 6747b47 - view on LGTM.com

new alerts:

• 3 for Constant condition
• 1 for Container contents are never accessed
• 1 for Useless assignment to local variable

fixed alerts:

• 1 for Missing Dispose call on local IDisposable

[lgtm-com]

This pull request introduces 4 alerts and fixes 1 when merging 7890cf6 into 6747b47 - view on LGTM.com

new alerts:

• 3 for Constant condition
• 1 for Container contents are never accessed

fixed alerts:

• 1 for Missing Dispose call on local IDisposable

[mregen]

almost ready, one more CTT pass then 🚀