Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The server library exposes some nodes with HasTypeDefinition reference to the same node. #1532

Closed
1 of 5 tasks
mrsuciu opened this issue Oct 4, 2021 · 2 comments · Fixed by #1574 or #1576
Closed
1 of 5 tasks

The server library exposes some nodes with HasTypeDefinition reference to the same node. #1532

mrsuciu opened this issue Oct 4, 2021 · 2 comments · Fixed by #1574 or #1576
Assignees
@mrsuciu

Comments

@mrsuciu
Copy link
Contributor

mrsuciu commented Oct 4, 2021

Type of Issue

  • Bug
  • Enhancement
  • Compliance
  • Question
  • Help wanted

Describe the Issue

The server library exposes some nodes with HasTypeDefinition reference to the same node.
e.g BaseObjectType\FolderType\FileDirectoryType\CreateDirectory

To Reproduce
The issue can be reproduced for any method in the objects from Opc.Ua.Core that has the m_typeDefinitionId = m_nodieId.
In BaseInstanceState.cs - PopulateBrowser method will add the m_typeDefinitionId to the list of refernces regardless of the fact that it is the same with curent node NodeId.
The question is why the methods have the same NodeId as their TypeDefinitionId when they are generated by the model compiler.

Expected behavior
Such circular reference should be avoided since one can enter an endless browse operation

Screenshots
image
@mrsuciu
Copy link
Contributor Author

mrsuciu commented Oct 13, 2021

This happens because the following values in Opc.Ua.PredefinedNodes are as follows

image

@mregen mregen mentioned this issue Oct 19, 2021
Closed
@mrsuciu mrsuciu mentioned this issue Oct 27, 2021
Closed
@mregen mregen mentioned this issue Nov 2, 2021
Merged
mregen pushed a commit that referenced this issue Nov 2, 2021
@opcfoundation-org
on node export only output TypeId for vars/objects (#1574)
0915063 
only output the DataTypeDefinitionId and ReferenceTypeId vor var/objects
fixes nodeset output of #1532 
fixes OPCFoundation/UA-ModelCompiler#94
@mregen
Copy link
Contributor

mregen commented Nov 2, 2021

The Opc.Ua.Core still needs new nodeset created with the fix

@mregen mregen reopened this Nov 2, 2021
@mregen mregen mentioned this issue Nov 3, 2021
Merged
mregen added a commit that referenced this issue Nov 4, 2021
@mregen
Fix binary export of surplus typedefinition (#1576)
7acddc0 
- HasTypeDefinition and TypeDefinitionId should only exist for Object/Variable in .uanodes
- fix binary export for .uanodes
- #1574 missed the binary output case, only fixed xml export
- fixes #1532 
- fixes OPCFoundation/UA-ModelCompiler#94
- fix the default and sample models in this repo

note --> ModelCompiler needs to use the updated core lib to produce the same output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrsuciu mrsuciu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mregen @mrsuciu